Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): support drop tip CTAs when two pipettes have tips attached #15984

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Aug 13, 2024

Overview

In 8.0, drop tip wiz now shows CTAs when a run is successful, and we determine tip attachment status solely from the history of tip attachment commands. Because of this, it's likely users will have protocols similar to the following:

left_pipette.pick_up_tip()   
[do something without dropping the tip explicitly in the protocol]
right_pipette.pick_up_tip()
[do something without dropping the tip explicitly in the protocol]
[end protocol]

In these situations, we want to prompt users to check tips on both pipettes.

This is simple in theory, but in practice, there are a lot of side-effects we have to consider: run status, whether the run is current, which app is controlling the robot, how to properly load the correct pipette...there's a lot of variables. Unfortunately, drop tip wizard in its current iteration is already overloaded and in need of a refactor. Following the control flow is difficult to say the least. If you're brave, #15947 offers some context behind the most recent systems created.

Test Plan and Hands on Testing

  • Smoke tested all drop tip flows and interactions, ensuring correct behavior. I used this protocol.

Changelog

  • New drop tip CTAs support dropping tips from two pipettes, if applicable.

Review requests

There is a lot we can do to clean this up, but this entire flow is getting a facelift for 8.1, so I think it's safe to focus on functionality for now.

Risk assessment

  • lowish-med. I smoke tested this thoroughly.

@mjhuff mjhuff requested a review from a team as a code owner August 13, 2024 19:00
setShowDTModal(false)
},
})

// Close the modal if a different app closes the run context.
React.useEffect(() => {
if (isRunCurrent && !isHomingPipettes) {
console.log('HITTING SET SHOW MODAL')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this leftover debugging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thank you!

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments but code changes look good to me

@mjhuff mjhuff merged commit 94f76ff into chore_release-8.0.0 Aug 13, 2024
20 checks passed
@mjhuff mjhuff deleted the app_drop-tip-handle-second-pipette branch August 13, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants