-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data): labware schema v3 #16027
Conversation
6a86c11
to
6bd53bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
As discussed in-person, we'll focus on the JSON Schema side of this first, and then update the Python and TS bindings when the dust has settled.
I think the JSON Schema needs some restructuring to work as intended. One way to test it is to feed it into a tool like this and click around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the JSON schema looks mostly right now, thanks! Just a few touchups:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And comments for the TypeScript part, when you get there.
Same deal. Looks basically right, just needing a few small touchups.
75fa041
to
610aae6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think linting is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me pending the inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
Overview
For static liquid tracking to convert between inner well heights and volumes, we need to have access to the inner dimensions of wells.
This adds a new labware schema to include inner well geometry, as well as typescript bindings for the new labware definition.
Changelog
radiusOfCurvature
variable name from python bindingTODO
Once we add actual labware definitions, we should add some python binding tests in
test_validations.py