Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): Correct "it's" to "its" in OT-2 calibration copy #16051

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix(app): Correct "it's" to "its" in OT-2 calibration copy #16051

merged 2 commits into from
Aug 19, 2024
+5 −9

Conversation

SyntaxColoring
Copy link
Contributor

Overview

This fixes a grammar error in OT-2 calibration.

Test Plan and Hands on Testing

None needed.

Changelog

it's -> its.

Review requests

None.

Risk assessment

None.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner August 19, 2024 16:27
@SyntaxColoring SyntaxColoring requested review from ncdiehl11 and removed request for a team August 19, 2024 16:27
mjhuff
mjhuff approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the test fix. thanks!

ecormany
ecormany approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ :shipit:

call it a fix and target on chore_release-8.0.0? prose can have bugs too.

@SyntaxColoring SyntaxColoring requested review from a team as code owners August 19, 2024 18:17
@SyntaxColoring SyntaxColoring changed the base branch from edge to chore_release-8.0.0 August 19, 2024 18:17
@SyntaxColoring SyntaxColoring changed the title refactor(app): Correct it's -> its fix(app): Correct it's -> its Aug 19, 2024
@SyntaxColoring SyntaxColoring merged commit 332fbf6 into chore_release-8.0.0 Aug 19, 2024
26 checks passed
@SyntaxColoring SyntaxColoring deleted the cal_block_copy_fix branch August 19, 2024 18:47
@SyntaxColoring SyntaxColoring changed the title fix(app): Correct it's -> its fix(app): Correct "it's" to "its" in OT-2 calibration copy Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@ecormany ecormany ecormany approved these changes

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11 ncdiehl11 is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyntaxColoring @ecormany @mjhuff