Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol-designer): default robot type to Flex on protocol onboarding #16059

Merged
merged 2 commits into from
Aug 20, 2024
Merged

feat(protocol-designer): default robot type to Flex on protocol onboarding #16059

merged 2 commits into from
Aug 20, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 19, 2024 •
edited
Loading

Overview

When creating a new protocol on PD, the wizard's first screen for robot selection should default to Flex.

closes AUTH-715

Test Plan and Hands on Testing

  • turn on PD redesign FF
  • create a new protocol
  • verify that on select robot page, the Flex option is preselected
Screen.Recording.2024-08-19.at.5.37.31.PM.mov

Changelog

  • update initial form state

Review requests

  • see test plan

Risk assessment

low

@ncdiehl11
feat(protocol-designer): default robot type to Flex on protocol onboa…
ee7f502 
…rding

When creating a new protocol on PD, the wizard's first screen for robot selection should default to
Flex.

closes AUTH-715
@ncdiehl11 ncdiehl11 requested a review from jerader August 19, 2024 21:37
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 19, 2024 21:45
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 19, 2024 21:45
koji
koji approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jerader
jerader reviewed Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! There are actually a few more steps that i'd like for you to fix if you don't mind.

  1. Go into the WizardFormState type and click on NewProtocolFields and change the robotType to just be RobotType.
  2. go to SelectRobot and remove the disabled prop

You might need to fix some checks/tests for the wizard for PD currently in prod since NewProtocolFields is used for both wizards, but not sure.

@ncdiehl11 ncdiehl11 requested a review from jerader August 20, 2024 13:57
@ncdiehl11
Copy link
Collaborator Author

thank you! There are actually a few more steps that i'd like for you to fix if you don't mind.

  1. Go into the WizardFormState type and click on NewProtocolFields and change the robotType to just be RobotType.
  2. go to SelectRobot and remove the disabled prop

You might need to fix some checks/tests for the wizard for PD currently in prod since NewProtocolFields is used for both wizards, but not sure.

Looks like nothing broke when updating that type!

jerader
jerader approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for fixing! lgtm!

@ncdiehl11 ncdiehl11 merged commit 8dcb457 into edge Aug 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@koji koji koji approved these changes

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdiehl11 @koji @jerader