Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abr-testing): ABR protocols and Liquid Set Ups #16728

Merged
merged 67 commits into from
Nov 8, 2024
Merged

Conversation

rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented Nov 7, 2024

Overview

Current ABR Protocols and Liquid Set Ups

Test Plan and Hands on Testing

All protocols have been simulated and ran on ABR robots successfully.

Changelog

  • Protocols include helper functions to load commonly used parameters, module/adapter/labware set ups, loading liquids, probing liquids, measuring height of loaded liquids
  • Protocols follow format and linting rules, excluding flake8 complexity score.

Review requests

Risk assessment

  • Protocols will no longer be able to be analyzed on the app, but will work on the robot as long as the abr-testing folder is pushed to it. However, protocols will still be analyzed using the abr make simulate command.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pushed a change to avoid linting the protocols.

@rclarke0 rclarke0 merged commit 18b0eb4 into edge Nov 8, 2024
53 of 58 checks passed
@rclarke0 rclarke0 deleted the add-abr-protocols branch November 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants