Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix layout and menu items of SlotOverflowMenu #16840

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Nov 14, 2024

Overview

This PR fixes the layout and content of SlotOverflowMenu component. It aligns text to the left of the menu button. Also, it always renders 'Add liquid' option, but disables if no labware is present in the slot. Last, it adds a Divider above 'Clear slot' option.

Closes RQA-3335

Test Plan and Hands on Testing

  • create or edit a protocol starting deck where some slots contain labware and others are empty
  • verify that 'Add liquid' menu item always shows, but is disabled if no labware is present in the slot
  • verify that divider line shows above 'clear slot'
  • verify that all text is aligned left

Changelog

  • update MenuButton css
  • fix logic for showing liquid menu item
  • add divider

Review requests

  • see test plan

Risk assessment

low

This PR fixes the layout and content of SlotOverflowMenu component. It aligns text to the left of
the menu button. Also, it always renders 'Add liquid' option, but disables if no labware is present
in the slot. Last, it adds a Divider above 'Clear slot' option.

Closes RQA-3335
@ncdiehl11 ncdiehl11 self-assigned this Nov 14, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 14, 2024 21:01
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 14, 2024 21:01
@ncdiehl11 ncdiehl11 requested review from koji, jerader and syao1226 and removed request for a team November 14, 2024 21:01
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 14, 2024 21:14
@ncdiehl11 ncdiehl11 removed the request for review from a team November 14, 2024 23:13
@ncdiehl11 ncdiehl11 requested a review from koji November 18, 2024 20:48
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
left a comment on data-testid

@ncdiehl11 ncdiehl11 merged commit d77329a into edge Nov 18, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants