-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer): fix layout and menu items of SlotOverflowMenu #16840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the layout and content of SlotOverflowMenu component. It aligns text to the left of the menu button. Also, it always renders 'Add liquid' option, but disables if no labware is present in the slot. Last, it adds a Divider above 'Clear slot' option. Closes RQA-3335
ncdiehl11
requested review from
koji,
jerader and
syao1226
and removed request for
a team
November 14, 2024 21:01
koji
reviewed
Nov 18, 2024
koji
reviewed
Nov 18, 2024
protocol-designer/src/pages/Designer/DeckSetup/SlotOverflowMenu.tsx
Outdated
Show resolved
Hide resolved
koji
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
left a comment on data-testid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the layout and content of SlotOverflowMenu component. It aligns text to the left of the menu button. Also, it always renders 'Add liquid' option, but disables if no labware is present in the slot. Last, it adds a Divider above 'Clear slot' option.
Closes RQA-3335
Test Plan and Hands on Testing
Changelog
MenuButton
cssReview requests
Risk assessment
low