Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components, protocol-designer): hug hotkey shortcut tag width #16936

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix(components, protocol-designer): hug hotkey shortcut tag width #16936

merged 4 commits into from
Nov 21, 2024
+31 −14

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Nov 21, 2024 •
edited
Loading

Overview

Add optional shrinkToContent prop to Tag component

Closes RQA-3667

Changelog

Test Plan and Hands on Testing

  • create or import a protocol and navigate to edit > timeline
  • verify that hotkey shortcuts at bottom left of screen matches new designs (copy + container hug)
Screenshot 2024-11-21 at 2 31 51 PM

Review requests

  • see test plan

Risk assessment

low

@ncdiehl11 ncdiehl11 requested review from koji and jerader November 21, 2024 19:44
@ncdiehl11 ncdiehl11 self-assigned this Nov 21, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 21, 2024 19:46
@ncdiehl11 ncdiehl11 requested review from a team as code owners November 21, 2024 19:46
@ncdiehl11 ncdiehl11 removed request for a team November 21, 2024 19:47
koji
koji approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 7411eaf into edge Nov 21, 2024
36 checks passed
@ncdiehl11 ncdiehl11 deleted the tag_fix-width branch November 21, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @koji