Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resolve directly in web-sdk #159

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Move resolve directly in web-sdk #159

merged 1 commit into from
Jan 9, 2025

Conversation

zapo
Copy link
Member

@zapo zapo commented Jan 9, 2025

Resolve has been implemented directly in wrappers and because of that its behavior was never fully implemented / on par with other operations and it doesn't benefit from new features.

  • passport would never be passed in resolve calls preventing resolving based on passport ID
  • calling resolve() as first call wouldn't respect initPassport
  • consent isn't handled and consent strings/signals aren't passed to edge like other endpoints
  • sdk version wouldn't be communicated to edge when using resolve

This PR corrects all of those issues by using the SDK's fetch() implementation.

@zapo zapo requested a review from Nikola-Milekic January 9, 2025 14:57
@zapo zapo merged commit 964a2f7 into master Jan 9, 2025
7 checks passed
@zapo zapo deleted the move-resolve-in-sdk branch January 9, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants