Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dev doc workflow for review when updating PR #66

Merged
merged 2 commits into from
Sep 20, 2024
Merged

chore: update dev doc workflow for review when updating PR #66

merged 2 commits into from
Sep 20, 2024

Conversation

florentmaitre
Copy link
Member

@florentmaitre florentmaitre commented Sep 16, 2024 •
edited by paulinea
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@florentmaitre florentmaitre linked an issue Sep 16, 2024 that may be closed by this pull request
Update Dev Doc Workflow for review when updating PR #64
Closed
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch 20 times, most recently from b6ef339 to c75b620 Compare September 18, 2024 15:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

🟢 Netlify deploy for commit f297e47 succeeded

Deploy preview: https://66ed4227c7eb822f973d9ea9--ouds-android.netlify.app
Deploy log: https://app.netlify.com/sites/ouds-android/deploys/66ed4227c7eb822f973d9ea9

@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch 2 times, most recently from a982210 to b256178 Compare September 18, 2024 16:37
github-actions bot added a commit that referenced this pull request Sep 18, 2024
@github-actions
Add QR code for 'docs: Update Dev Doc Workflow for review when updati…
d44fda6 
…ng PR (#66)'
@Orange-OpenSource Orange-OpenSource deleted a comment from github-actions bot Sep 18, 2024
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch 4 times, most recently from fd6bea5 to 22f8703 Compare September 19, 2024 09:00
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch 3 times, most recently from 62b994b to 326cf11 Compare September 19, 2024 13:31
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch from 326cf11 to cb429d2 Compare September 19, 2024 14:05
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch from cb429d2 to 18255b1 Compare September 19, 2024 15:06
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch from 18255b1 to c47b5b9 Compare September 19, 2024 15:12
@paulinea paulinea changed the title docs: Update Dev Doc Workflow for review when updating PR docs: update dev doc workflow for review when updating PR Sep 19, 2024
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch from c47b5b9 to ef72093 Compare September 19, 2024 15:18
@paulinea paulinea self-requested a review September 20, 2024 09:30
@florentmaitre florentmaitre force-pushed the 64-update-dev-doc-workflow-for-review-when-updating-pr branch from ef72093 to f297e47 Compare September 20, 2024 09:31
@paulinea paulinea changed the title docs: update dev doc workflow for review when updating PR chore: update dev doc workflow for review when updating PR Sep 20, 2024
@paulinea paulinea merged commit 969d4c7 into develop Sep 20, 2024
8 checks passed
@paulinea paulinea deleted the 64-update-dev-doc-workflow-for-review-when-updating-pr branch September 20, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulinea paulinea paulinea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Dev Doc Workflow for review when updating PR
2 participants
@florentmaitre @paulinea