Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(border): change semantic tokens for border width #69

Merged
merged 1 commit into from
Sep 20, 2024
Merged

feat(border): change semantic tokens for border width #69

merged 1 commit into from
Sep 20, 2024

Conversation

paulinea
Copy link
Member

@paulinea paulinea commented Sep 19, 2024 •
edited by florentmaitre
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@paulinea paulinea linked an issue Sep 19, 2024 that may be closed by this pull request
Change some border width semantic tokens #67
Closed
@florentmaitre florentmaitre merged commit d927fdd into develop Sep 20, 2024
7 checks passed
@florentmaitre florentmaitre deleted the 67-change-some-border-width-semantic-tokens branch September 20, 2024 09:29
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
303e933 
# 1.0.0 (2024-10-08)

### Bug Fixes

* apply naming rules ([#28](#28)) ([881d2b2](881d2b2))
* change product name in CONTRIBUTING.md ([efa6c35](efa6c35))
* change product name in README.md ([7430628](7430628))
* **deps:** update dependency androidx.activity:activity-compose to v1.9.2 ([#79](#79)) ([b755d48](b755d48))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.02 ([#80](#80)) ([b58c8de](b58c8de))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.03 ([#100](#100)) ([ef7752e](ef7752e))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.1 ([#85](#85)) ([4910d52](4910d52))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.2 ([#101](#101)) ([0a534b8](0a534b8))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.27.0 ([#86](#86)) ([ef98d7b](ef98d7b))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.28.0 ([#102](#102)) ([510a529](510a529))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.3.0 ([#87](#87)) ([505a070](505a070))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.4.0 ([#99](#99)) ([376d462](376d462))
* **deps:** update dependency org.mockito:mockito-android to v5.13.0 ([#89](#89)) ([df22cae](df22cae))
* **deps:** update dependency org.mockito:mockito-android to v5.14.1 ([#94](#94)) ([8a8ea8b](8a8ea8b))
* **deps:** update dependency org.mockito.kotlin:mockito-kotlin to v5.4.0 ([#88](#88)) ([dc99148](dc99148))
* **deps:** update grpc-java monorepo to v1.68.0 ([#93](#93)) ([d0f00c3](d0f00c3))
* **deps:** update zxing to v3.5.3 ([#81](#81)) ([bc318d8](bc318d8))
* set up 2 assignees in the issues templates ([083c8dc](083c8dc))
* set up 2 assignees in the issues templates ([9e58305](9e58305))
* set up 2 assignees in the issues templates ([043105c](043105c))
* typo in CONTRIBUTING.md ([77c9e5f](77c9e5f))
* update Renovate to target the main branch ([c8b2949](c8b2949))

### Features

* add border tokens ([#54](#54)) ([c238e91](c238e91))
* add elevation tokens ([#62](#62)) ([6debb88](6debb88))
* add font tokens and theme typography ([#97](#97)) ([80175df](80175df))
* add grid tokens ([#65](#65)) ([351e671](351e671))
* add opacity tokens ([#53](#53)) ([7da8a10](7da8a10))
* **border:** change semantic tokens for border width ([#69](#69)) ([d927fdd](d927fdd))
* create the basic architecture of the demo application ([#31](#31)) ([8dbc9af](8dbc9af))
* create the basic architecture of the library ([#32](#32)) ([254469c](254469c))
* implement tokens architecture ([#52](#52)) ([f5e6863](f5e6863))
* **opacity:** rename opacity-emphasis to opacity-strong ([#63](#63)) ([ad68075](ad68075))
* **opacity:** update `opacity800` from `0.88f` to `0.80f` ([#60](#60)) ([c477551](c477551))
* update font tokens to match with Tokenator generated files ([#107](#107)) ([51c79f4](51c79f4))
* update semantic tokens architecture ([#104](#104)) ([bca2b64](bca2b64))
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@semantic-release-bot
chore(release): 1.0.0-dryrun.1 [skip ci]
1673f6b 
# 1.0.0-dryrun.1 (2024-10-08)

### Bug Fixes

* apply naming rules ([#28](#28)) ([881d2b2](881d2b2))
* change product name in CONTRIBUTING.md ([efa6c35](efa6c35))
* change product name in README.md ([7430628](7430628))
* **deps:** update dependency androidx.activity:activity-compose to v1.9.2 ([#79](#79)) ([b755d48](b755d48))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.02 ([#80](#80)) ([b58c8de](b58c8de))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.03 ([#100](#100)) ([ef7752e](ef7752e))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.1 ([#85](#85)) ([4910d52](4910d52))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.2 ([#101](#101)) ([0a534b8](0a534b8))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.27.0 ([#86](#86)) ([ef98d7b](ef98d7b))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.28.0 ([#102](#102)) ([510a529](510a529))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.3.0 ([#87](#87)) ([505a070](505a070))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.4.0 ([#99](#99)) ([376d462](376d462))
* **deps:** update dependency org.mockito:mockito-android to v5.13.0 ([#89](#89)) ([df22cae](df22cae))
* **deps:** update dependency org.mockito:mockito-android to v5.14.1 ([#94](#94)) ([8a8ea8b](8a8ea8b))
* **deps:** update dependency org.mockito.kotlin:mockito-kotlin to v5.4.0 ([#88](#88)) ([dc99148](dc99148))
* **deps:** update grpc-java monorepo to v1.68.0 ([#93](#93)) ([d0f00c3](d0f00c3))
* **deps:** update zxing to v3.5.3 ([#81](#81)) ([bc318d8](bc318d8))
* set up 2 assignees in the issues templates ([083c8dc](083c8dc))
* set up 2 assignees in the issues templates ([9e58305](9e58305))
* set up 2 assignees in the issues templates ([043105c](043105c))
* typo in CONTRIBUTING.md ([77c9e5f](77c9e5f))
* update Renovate to target the main branch ([c8b2949](c8b2949))

### Features

* add border tokens ([#54](#54)) ([c238e91](c238e91))
* add elevation tokens ([#62](#62)) ([6debb88](6debb88))
* add font tokens and theme typography ([#97](#97)) ([80175df](80175df))
* add grid tokens ([#65](#65)) ([351e671](351e671))
* add opacity tokens ([#53](#53)) ([7da8a10](7da8a10))
* **border:** change semantic tokens for border width ([#69](#69)) ([d927fdd](d927fdd))
* create the basic architecture of the demo application ([#31](#31)) ([8dbc9af](8dbc9af))
* create the basic architecture of the library ([#32](#32)) ([254469c](254469c))
* implement tokens architecture ([#52](#52)) ([f5e6863](f5e6863))
* **opacity:** rename opacity-emphasis to opacity-strong ([#63](#63)) ([ad68075](ad68075))
* **opacity:** update `opacity800` from `0.88f` to `0.80f` ([#60](#60)) ([c477551](c477551))
* update font tokens to match with Tokenator generated files ([#107](#107)) ([51c79f4](51c79f4))
* update semantic tokens architecture ([#104](#104)) ([bca2b64](bca2b64))
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@semantic-release-bot
chore(release): 1.0.0-dryrun.1 [skip ci]
5b2a1ed 
# 1.0.0-dryrun.1 (2024-10-08)

### Bug Fixes

* apply naming rules ([#28](#28)) ([881d2b2](881d2b2))
* change product name in CONTRIBUTING.md ([efa6c35](efa6c35))
* change product name in README.md ([7430628](7430628))
* **deps:** update dependency androidx.activity:activity-compose to v1.9.2 ([#79](#79)) ([b755d48](b755d48))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.02 ([#80](#80)) ([b58c8de](b58c8de))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.03 ([#100](#100)) ([ef7752e](ef7752e))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.1 ([#85](#85)) ([4910d52](4910d52))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.2 ([#101](#101)) ([0a534b8](0a534b8))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.27.0 ([#86](#86)) ([ef98d7b](ef98d7b))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.28.0 ([#102](#102)) ([510a529](510a529))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.3.0 ([#87](#87)) ([505a070](505a070))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.4.0 ([#99](#99)) ([376d462](376d462))
* **deps:** update dependency org.mockito:mockito-android to v5.13.0 ([#89](#89)) ([df22cae](df22cae))
* **deps:** update dependency org.mockito:mockito-android to v5.14.1 ([#94](#94)) ([8a8ea8b](8a8ea8b))
* **deps:** update dependency org.mockito.kotlin:mockito-kotlin to v5.4.0 ([#88](#88)) ([dc99148](dc99148))
* **deps:** update grpc-java monorepo to v1.68.0 ([#93](#93)) ([d0f00c3](d0f00c3))
* **deps:** update zxing to v3.5.3 ([#81](#81)) ([bc318d8](bc318d8))
* set up 2 assignees in the issues templates ([083c8dc](083c8dc))
* set up 2 assignees in the issues templates ([9e58305](9e58305))
* set up 2 assignees in the issues templates ([043105c](043105c))
* typo in CONTRIBUTING.md ([77c9e5f](77c9e5f))
* update Renovate to target the main branch ([c8b2949](c8b2949))

### Features

* add border tokens ([#54](#54)) ([c238e91](c238e91))
* add elevation tokens ([#62](#62)) ([6debb88](6debb88))
* add font tokens and theme typography ([#97](#97)) ([80175df](80175df))
* add grid tokens ([#65](#65)) ([351e671](351e671))
* add opacity tokens ([#53](#53)) ([7da8a10](7da8a10))
* **border:** change semantic tokens for border width ([#69](#69)) ([d927fdd](d927fdd))
* create the basic architecture of the demo application ([#31](#31)) ([8dbc9af](8dbc9af))
* create the basic architecture of the library ([#32](#32)) ([254469c](254469c))
* implement tokens architecture ([#52](#52)) ([f5e6863](f5e6863))
* **opacity:** rename opacity-emphasis to opacity-strong ([#63](#63)) ([ad68075](ad68075))
* **opacity:** update `opacity800` from `0.88f` to `0.80f` ([#60](#60)) ([c477551](c477551))
* update font tokens to match with Tokenator generated files ([#107](#107)) ([51c79f4](51c79f4))
* update semantic tokens architecture ([#104](#104)) ([bca2b64](bca2b64))
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@semantic-release-bot
chore(release): 1.0.0-dryrun.1 [skip ci]
426b2ed 
# 1.0.0-dryrun.1 (2024-10-08)

### Bug Fixes

* apply naming rules ([#28](#28)) ([881d2b2](881d2b2))
* change product name in CONTRIBUTING.md ([efa6c35](efa6c35))
* change product name in README.md ([7430628](7430628))
* **deps:** update dependency androidx.activity:activity-compose to v1.9.2 ([#79](#79)) ([b755d48](b755d48))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.02 ([#80](#80)) ([b58c8de](b58c8de))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.03 ([#100](#100)) ([ef7752e](ef7752e))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.1 ([#85](#85)) ([4910d52](4910d52))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.2 ([#101](#101)) ([0a534b8](0a534b8))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.27.0 ([#86](#86)) ([ef98d7b](ef98d7b))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.28.0 ([#102](#102)) ([510a529](510a529))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.3.0 ([#87](#87)) ([505a070](505a070))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.4.0 ([#99](#99)) ([376d462](376d462))
* **deps:** update dependency org.mockito:mockito-android to v5.13.0 ([#89](#89)) ([df22cae](df22cae))
* **deps:** update dependency org.mockito:mockito-android to v5.14.1 ([#94](#94)) ([8a8ea8b](8a8ea8b))
* **deps:** update dependency org.mockito.kotlin:mockito-kotlin to v5.4.0 ([#88](#88)) ([dc99148](dc99148))
* **deps:** update grpc-java monorepo to v1.68.0 ([#93](#93)) ([d0f00c3](d0f00c3))
* **deps:** update zxing to v3.5.3 ([#81](#81)) ([bc318d8](bc318d8))
* set up 2 assignees in the issues templates ([083c8dc](083c8dc))
* set up 2 assignees in the issues templates ([9e58305](9e58305))
* set up 2 assignees in the issues templates ([043105c](043105c))
* typo in CONTRIBUTING.md ([77c9e5f](77c9e5f))
* update Renovate to target the main branch ([c8b2949](c8b2949))

### Features

* add border tokens ([#54](#54)) ([c238e91](c238e91))
* add elevation tokens ([#62](#62)) ([6debb88](6debb88))
* add font tokens and theme typography ([#97](#97)) ([80175df](80175df))
* add grid tokens ([#65](#65)) ([351e671](351e671))
* add opacity tokens ([#53](#53)) ([7da8a10](7da8a10))
* **border:** change semantic tokens for border width ([#69](#69)) ([d927fdd](d927fdd))
* create the basic architecture of the demo application ([#31](#31)) ([8dbc9af](8dbc9af))
* create the basic architecture of the library ([#32](#32)) ([254469c](254469c))
* implement tokens architecture ([#52](#52)) ([f5e6863](f5e6863))
* **opacity:** rename opacity-emphasis to opacity-strong ([#63](#63)) ([ad68075](ad68075))
* **opacity:** update `opacity800` from `0.88f` to `0.80f` ([#60](#60)) ([c477551](c477551))
* update font tokens to match with Tokenator generated files ([#107](#107)) ([51c79f4](51c79f4))
* update semantic tokens architecture ([#104](#104)) ([bca2b64](bca2b64))
github-actions bot pushed a commit that referenced this pull request Oct 9, 2024
@semantic-release-bot
chore(release): 1.0.0-dryrun.1 [skip ci]
b6ea4c2 
# 1.0.0-dryrun.1 (2024-10-09)

### Bug Fixes

* apply naming rules ([#28](#28)) ([881d2b2](881d2b2))
* change product name in CONTRIBUTING.md ([efa6c35](efa6c35))
* change product name in README.md ([7430628](7430628))
* **deps:** update dependency androidx.activity:activity-compose to v1.9.2 ([#79](#79)) ([b755d48](b755d48))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.02 ([#80](#80)) ([b58c8de](b58c8de))
* **deps:** update dependency androidx.compose:compose-bom to v2024.09.03 ([#100](#100)) ([ef7752e](ef7752e))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.1 ([#85](#85)) ([4910d52](4910d52))
* **deps:** update dependency androidx.navigation:navigation-compose to v2.8.2 ([#101](#101)) ([0a534b8](0a534b8))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.27.0 ([#86](#86)) ([ef98d7b](ef98d7b))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.28.0 ([#102](#102)) ([510a529](510a529))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.3.0 ([#87](#87)) ([505a070](505a070))
* **deps:** update dependency com.google.firebase:firebase-bom to v33.4.0 ([#99](#99)) ([376d462](376d462))
* **deps:** update dependency org.mockito:mockito-android to v5.13.0 ([#89](#89)) ([df22cae](df22cae))
* **deps:** update dependency org.mockito:mockito-android to v5.14.1 ([#94](#94)) ([8a8ea8b](8a8ea8b))
* **deps:** update dependency org.mockito.kotlin:mockito-kotlin to v5.4.0 ([#88](#88)) ([dc99148](dc99148))
* **deps:** update grpc-java monorepo to v1.68.0 ([#93](#93)) ([d0f00c3](d0f00c3))
* **deps:** update zxing to v3.5.3 ([#81](#81)) ([bc318d8](bc318d8))
* set up 2 assignees in the issues templates ([083c8dc](083c8dc))
* set up 2 assignees in the issues templates ([9e58305](9e58305))
* set up 2 assignees in the issues templates ([043105c](043105c))
* typo in CONTRIBUTING.md ([77c9e5f](77c9e5f))
* update Renovate to target the main branch ([c8b2949](c8b2949))

### Features

* add border tokens ([#54](#54)) ([c238e91](c238e91))
* add dimension tokens ([#68](#68)) ([8c3b38a](8c3b38a))
* add elevation tokens ([#62](#62)) ([6debb88](6debb88))
* add font tokens and theme typography ([#97](#97)) ([80175df](80175df))
* add grid tokens ([#65](#65)) ([351e671](351e671))
* add opacity tokens ([#53](#53)) ([7da8a10](7da8a10))
* **border:** change semantic tokens for border width ([#69](#69)) ([d927fdd](d927fdd))
* create the basic architecture of the demo application ([#31](#31)) ([8dbc9af](8dbc9af))
* create the basic architecture of the library ([#32](#32)) ([254469c](254469c))
* implement tokens architecture ([#52](#52)) ([f5e6863](f5e6863))
* **opacity:** rename opacity-emphasis to opacity-strong ([#63](#63)) ([ad68075](ad68075))
* **opacity:** update `opacity800` from `0.88f` to `0.80f` ([#60](#60)) ([c477551](c477551))
* update font tokens to match with Tokenator generated files ([#107](#107)) ([51c79f4](51c79f4))
* update semantic tokens architecture ([#104](#104)) ([bca2b64](bca2b64))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentmaitre florentmaitre florentmaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change some border width semantic tokens
2 participants
@paulinea @florentmaitre