Macro'ed out GETHOSTBYNAME, and fixed if-statement braces to be on a …

…new line for consistency
OrebroUniversity · Oct 30, 2014 · 5592ff9 · 5592ff9
1 parent aa9b575
commit 5592ff9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/simple_message/include/simple_message/socket/simple_socket.h b/simple_message/include/simple_message/socket/simple_socket.h
@@ -69,6 +69,7 @@
 #endif
 #define INET_ADDR(str) inet_addr(str)
 #define SOCKLEN_T socklen_t
+#define GETHOSTBYNAME(str) gethostbyname(str)
 
 #endif
 
@@ -110,6 +111,7 @@ extern "C" STATUS setsockopt (   /* remove "extern C", if you're using C instead
 #define HTONS(num) mpHtons(num)
 #define INET_ADDR(str) mpInetAddr(str)
 #define SOCKLEN_T unsigned int
+#define GETHOSTBYNAME(str) NULL
 
 #endif
 

diff --git a/simple_message/include/simple_message/socket/tcp_socket.h b/simple_message/include/simple_message/socket/tcp_socket.h
@@ -42,7 +42,7 @@
 
 #ifdef LINUXSOCKETS
 #include "sys/socket.h"
-#include "netdb.h"		/* gethostbyname */
+#include "netdb.h"
 #include "arpa/inet.h"
 #include "string.h"
 #include "unistd.h"

diff --git a/simple_message/src/socket/tcp_client.cpp b/simple_message/src/socket/tcp_client.cpp
@@ -72,14 +72,18 @@ bool TcpClient::init(char *buff, int port_num)
       LOG_WARN("Failed to set no socket delay, sending data can be delayed by up to 250ms");
     }
 
-
     // Initialize address data structure
     memset(&this->sockaddr_, 0, sizeof(this->sockaddr_));
     this->sockaddr_.sin_family = AF_INET;
-    if (NULL != (ent = gethostbyname(buff))) {
+
+    // Check for 'buff' as hostname, and use that, otherwise assume IP address
+    if (NULL != (ent = GETHOSTBYNAME(buff)))
+    {
       in_a = (struct in_addr *) ent->h_addr_list[0];
       this->sockaddr_.sin_addr.s_addr = in_a->s_addr;
-    } else {
+    }
+    else 
+    {
       this->sockaddr_.sin_addr.s_addr = INET_ADDR(buff);
     }
     this->sockaddr_.sin_port = HTONS(port_num);