feat: financial-statement from origin-defi
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelugolini
temporarily deployed
to
preview-oeth-feat-finan-em7dvw
apexearth
force-pushed
the
feat/financial-statement
branch
from
9fd56cb to
e5c6af4
Compare
rafaelugolini
had a problem deploying
to
preview-oeth-feat-finan-em7dvw
rafaelugolini
had a problem deploying
to
preview-oeth-feat-finan-em7dvw
rafaelugolini
had a problem deploying
to
preview-oeth-feat-finan-em7dvw
rafaelugolini
temporarily deployed
to
preview-oeth-feat-finan-em7dvw
- change title - loading spinner - per-column rate conversions - hide 'PROTOCOL NET VALUE' when negative o_0 - column alignment - remove hover bold - set arrow gray - 0 decimal usd prices, unless compacted - 3 decimal eth prices, unless compacted
- reverse column order, showing now first - change column header formatting & refine dates shown
- tweak negative color
# Conflicts: # package.json # yarn.lock
rafaelugolini
had a problem deploying
to
preview-oeth-feat-finan-jt2oph
toniocodo
approved these changes
Oct 4, 2023
| "wagmi": "^0.12.7" | ||
| "usehooks-ts": "^2.9.1", | ||
| "viem": "^1.10.12", | ||
| "wagmi": "^1.4.1" |
There was a problem hiding this comment.
wagmi v1 introduced quite a lot of changes, are you sure to bump version? In case of, they still maintain 0.12.x 😓
There was a problem hiding this comment.
It wasn't used in many places and I made the changes to accommodate the new bigint types returned.
| @@ -40,9 +42,13 @@ | |||
| "sanitize-html": "^2.10.0", | |||
| "tailwind-merge": "^1.12.0", | |||
| "tailwindcss": "^3.3.1", | |||
| "wagmi": "^0.12.7" | |||
| "usehooks-ts": "^2.9.1", | |||
| "viem": "^1.10.12", | |||
There was a problem hiding this comment.
this is replacement for ethers.js, quite a lot of breaking changes
There was a problem hiding this comment.
Yes though we already had wagmi in the project. What I did here is upgrade wagmi and it was used in very few places.
- remove `react-intl`
- add balancer aura strategy - remove some useless generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/OriginProtocol/origin-defi/pull/54