This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Pushed OrionLauncher module to the point of compiling #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will look into this PR today. |
mikroskeem
suggested changes
Aug 17, 2020
| @@ -27,8 +27,10 @@ | |||
|
|
|||
| import org.checkerframework.checker.nullness.qual.NonNull; | |||
|
|
|||
| import java.io.IOException; | |||
| import javax.net.ssl.HttpsURLConnection; | |||
| import java.io.*; | |||
There was a problem hiding this comment.
No star imports please
| if(response.code() != 200) | ||
|
|
||
| try { | ||
| HttpsURLConnection connection = |
There was a problem hiding this comment.
Use HttpURLConnection instead.
| HttpsURLConnection connection = | ||
| (HttpsURLConnection) paperclipDownloadUrl.openConnection(); | ||
|
|
||
| connection.addRequestProperty("user-agent", "OrionMinecraft"); |
…errors. ~untested
Crypnotic
force-pushed
the
feature/overhaul
branch
from
84e41e5
to
38bdf57
Compare
|
Requested changes made |
|
Regarding the progress, readme has Discord link where we can discuss about ideas. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure where progress lies with #14, but I've rewrote the bits of the launcher module that needed to be fixed after removing
OkHttpandShuriken. Downloading should work just fine, but I haven't had the time to test since it was a copy/paste from another project I am working on.I hope this helps to get the project moving forward again :)