Added nginx ssl cyphers #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this partly fixes #24 |
ghost
reviewed
Mar 10, 2018
| gzip on; | ||
| gzip_disable "msie6"; | ||
|
|
||
| ssl_protocols TLSv1 TLSv1.1 TLSv1.2; |
There was a problem hiding this comment.
we should not advocate the use of TLSv1.0 https://www.lexiconn.com/blog/2015/12/pci-council-pushes-back-tls-1-0-end-of-life-date-to-june-2018/
ghost
reviewed
Mar 10, 2018
|
|
||
| include /etc/nginx/mime.types; | ||
| default_type application/octet-stream; | ||
|
|
||
| include /etc/nginx/conf.d/*.conf; | ||
| include /etc/nginx/sites-available/*; |
There was a problem hiding this comment.
I had to manually create the symlinks between /etc/nginx/sites-available/*.conf and /etc/nginx/sites-enabled/*.confshould we do it in the Dockerfile instead?
There was a problem hiding this comment.
@0x13A sites-enabled is not currently used in the nginx image. Take a look at the https://github.com/Osedea/nodock/blob/master/nginx/scripts/build-nginx.sh script for how the current configs are added to sites-available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.