Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pandas missing dependency to setup.py #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juanesarango
Copy link

@juanesarango juanesarango commented Jul 17, 2024

Problem

Pandas==1.0.3 dependency is missing in setup.py, causing it to fail when installing it with pip.

ALLSorts/setup.py

Lines 16 to 23 in be43d6c

install_requires=[
"joblib==0.15.1",
"matplotlib==3.2.1",
"scikit-learn==0.22.1",
"umap-learn==0.4.4",
"plotly==4.14.3",
"kaleido==0.1.0"
],

Notice pandas is correctly defined in the conda environment file:

dependencies:
- joblib=0.15.1
- matplotlib=3.2.1
- numpy=1.18.1
- pandas=1.0.3
- pip=20.0.2
- python=3.8.3
- scikit-learn=0.22.1
- scipy=1.4.1
- setuptools=46.4.0
- umap-learn=0.4.4
- plotly==4.14.3
- numba==0.52.0

Replicate error

$ pip install git+https://github.com/Oshlack/ALLSorts@be43d6c#egg=ALLSorts
$ ALLSorts --help
Traceback (most recent call last):
  File "/tmp/allsorts_virtualenv/bin/ALLSorts", line 5, in <module>
    from ALLSorts.allsorts import run
  File "/tmp/allsorts_virtualenv/lib/python3.6/site-packages/ALLSorts/allsorts.py", line 27, in <module>
    import pandas as pd
ModuleNotFoundError: No module named 'pandas'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant