Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript GUI translation #24

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

caveman99
Copy link
Contributor

  • factored out the javascript into separate files. The app.js.gz is produced by concatenating them, running uglifyjs and gzipping the result. Flash Footprint is smaller than before without the translations. The old custom code now lives in main.js
  • replaced index.html with index.html.gz saving even more flash space.

@chegewara
Copy link
Collaborator

Thanks, but GUI is not finished yet, so we could wait with it a bit.

@caveman99
Copy link
Contributor Author

Thought i'd share, because its running well on my test mule.

@Tysonpower
Copy link
Collaborator

I would just leave alone the GUI...it is generated new each time something is Changed on it and it is small enough. It would only complicate building the Firmware and the few kb will not improve Performance or anything really.

@caveman99
Copy link
Contributor Author

@Tysonpower The GUI translations module was added from my understanding that not everyone especially in developing countries can speak english. Half of Africa is french speaking only and S/W Africa is German speaking. The compression then was the next step in my mind to save flash space for more translations than the provided German and French. And the thing i actually used for translations was quite low key and client side only. Feel free to ditch compression or ditch the translations alltogether if not deemed neccessary.

@Tysonpower
Copy link
Collaborator

Translation is a good Idea, but i wonder if there is a better Solution for it. I would suggest leaving it for now in english, if i find a good way to implement multi Language we can use part of your Translations to make it all happen 👍

PS: "Durchstöbern Sie alle Dateien, die vom Himmel heruntergeladen wurden" würde ich anders Übersetzen 😄

@caveman99
Copy link
Contributor Author

The translations itself were not the most carefully prepared part of this all. More like 'i need some samples quick to see if this works' Maybe if you take the source file and put it into several machine translation services, you'll find out where i got it from ;-) It's not Google Translate but still far from perfect, 100% agreed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants