Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ability to use ollama running remotely #172

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

mjspeck
Copy link
Contributor

@mjspeck mjspeck commented Mar 1, 2024

Refs: #171

What does this PR do?

Adds ability to use remote ollama server

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected. Make sure before submmiting this PR you run tests with evaluate.py

@mjspeck
Copy link
Contributor Author

mjspeck commented Mar 6, 2024

@joshbickett would someone have a moment to look at this? It's a really small PR that could be useful to anyone running ollama on a remote server.

@joshbickett
Copy link
Contributor

@mjspeck thanks for the PR. I'll try to look at it by the end of the week. If you don't hear from me feel free to ping again.

@slapglif
Copy link

pls merge this its good

@joshbickett
Copy link
Contributor

@slapglif @mjspeck I'm re prioritizing this project. I'll try to take a look at this soon

@mjspeck
Copy link
Contributor Author

mjspeck commented Jan 2, 2025

@joshbickett just fixed the small merge conflict. Let me know if there are any other changes you need.

@mjspeck
Copy link
Contributor Author

mjspeck commented Jan 22, 2025

@joshbickett any chance to look at this soon?

@joshbickett
Copy link
Contributor

looking now

@joshbickett joshbickett merged commit 6c91917 into OthersideAI:main Jan 23, 2025
@joshbickett
Copy link
Contributor

joshbickett commented Jan 23, 2025

@mjspeck I didn't test the remote Llama functionality but it passed some basic test for me and didn't appear to break any existing functionality. Do you think it is worth adding running llama to the Readme? Let me know if you're interested!

Sorry again for the delay. I've been very busy lately. I want to revisit this project so I'm going to be more responsive now.

@mjspeck
Copy link
Contributor Author

mjspeck commented Jan 23, 2025

Couldn't hurt. I can try to find some time soon if you wanna assign the issue to me.

@mjspeck mjspeck deleted the upstream-main branch January 28, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants