refactor: move name option inside cookieOptions

OtterJS · Aug 27, 2024 · 0a17e5c · 0a17e5c
1 parent 0f7c8f6
commit 0a17e5c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/session.ts b/src/session.ts
@@ -13,11 +13,11 @@ export default function session<
 >(options: Options = {}) {
   type TypedSession = Session<T>
 
-  const name = options.name || "sid"
   const store = options.store || new MemoryStore()
   const genId = options.genid || nanoid
   const touchAfter = options.touchAfter ?? -1
-  const { unsign, ...cookieOpts } = options.cookie ?? {}
+  const { name: maybeName, unsign, ...cookieOpts } = options.cookie ?? {}
+  const name = maybeName ?? "sid"
 
   function decorateSession(req: Req, res: Res, session: TypedSession, id: string, _now: number) {
     Object.defineProperties(session, {

diff --git a/src/types.ts b/src/types.ts
@@ -38,12 +38,13 @@ export interface SessionStore {
 }
 
 export interface Options {
-  name?: string | undefined
   store?: SessionStore | undefined
   genid?: (() => string) | undefined
   touchAfter?: number | undefined
   cookie?:
     | (Partial<Exclude<Cookie, "expires">> & {
+        name?: string | undefined
+
         /**
          * `otterhttp` cookie `sign` function, will be passed to `res.cookie`.
          * @default undefined