Homework RxJava Белянин Роман #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZadorozhnyiSemen
suggested changes
May 7, 2022
| import retrofit2.http.GET | ||
|
|
||
| interface CatsService { | ||
|
|
||
| @GET("random?animal_type=cat") | ||
| fun getCatFact(): Call<Fact> | ||
| fun getCatFact(): Flowable<Fact> |
There was a problem hiding this comment.
Flowable подразумевает что мы будем получать поток данных, в данном случае достаточно Single, но и Flowable и Observable - валидные типы для работы с запросами
| return Flowable.empty() | ||
| return generateCatFact() | ||
| .repeatWhen { it.delay (2, TimeUnit.SECONDS) } | ||
| .distinct() |
There was a problem hiding this comment.
вот тут нужно быть аккуратнее, можно посмотреть марбл диаграмму в документации метода - distinct возвращает только уникальные элементы, т.е. в какой-то момент поток данных может прекратиться, когда мы пропушим весь список, лучше использовать distinctUntilChanged
There was a problem hiding this comment.
можете попробовать перевести телефон/эмулятор в авиарежим, сразу будет понятен результат
|
Исправил |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homework RxJava