CustomView and Animation homework #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonkazakov
requested changes
Dec 25, 2022
| } | ||
| } | ||
|
|
||
| override fun onMeasure(widthMeasureSpec: Int, heightMeasureSpec: Int) { |
There was a problem hiding this comment.
А ты не хочешь тут описать логику расчетов?
| return super.onTouchEvent(event) | ||
| } | ||
|
|
||
| private fun animation() { |
There was a problem hiding this comment.
Мне кажется что у тебя тут ошибка, как то странно выглядит выбранный сектор на первой картинке
| pie.paint.strokeWidth = if(pie.isClicked) 20f else 0f | ||
| } | ||
| } | ||
| requestLayout() |
There was a problem hiding this comment.
а зачем нужен вызов requestLayout?
| private var bOffset = 0f | ||
| private var animWidth = 0f | ||
| private var clickedPie: PiePiece? = null | ||
| private val animatorSet = AnimatorSet() |
| attrs: AttributeSet? = null, | ||
| defStyleAttr: Int = 0 | ||
| ) : View(context, attrs, defStyleAttr) { | ||
| private var animator: ValueAnimator = ValueAnimator.ofFloat() |
There was a problem hiding this comment.
Он разве нужен на уровне класса?
| fun onClick(category: String) | ||
| } | ||
|
|
||
| class PieChartView @JvmOverloads constructor( |
There was a problem hiding this comment.
Реализуй, пожалуйста, сохранение/восстановление стейта
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.