Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone 2.0 - User scope views, Discoverable Groups & Patches #340

Merged
merged 138 commits into from
Sep 17, 2020
Merged

Milestone 2.0 - User scope views, Discoverable Groups & Patches #340

merged 138 commits into from
Sep 17, 2020
+12,039 −4,722

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Jul 24, 2020 •
edited
Loading

summary of main features and changes

  • add discoverable groups (publicly available for self-registration by user to become member of that group)
  • add user-scoped views that allow operations such as self-edit user information & self-registration to discoverable groups
  • add +120 test cases for new features & others for existing features that were not fully tested
  • improve UI with many rendering tweaks (eg: modified theme, display version information, etc.)
  • display errors with UI page when API results into invalid operation (e.g.: unauthorized)
  • multiple fixes to expected behavior but previously not completely fulfilled as intended (validated by new tests)
  • reduce produced outputs for non-admin users to avoid "leaking" some details they don't need (should not) know
  • obsolete many routes formats that where deprecated for an extremely long time
  • convert PUT to PATCH since this is the RESTful method for partial update (relates to [Feature] Allow PUT operations similarly to PATCH requests #349)
  • many docs update for permissions and explanations of features

full changelog (quite massive, see for details)

https://github.com/Ouranosinc/Magpie/blob/user-scope-views/CHANGES.rst#200-2020-07-31

other

@fmigneault fmigneault added the WIP label Jul 24, 2020
@fmigneault fmigneault added this to the 2.x.x milestone Jul 24, 2020
@fmigneault fmigneault self-assigned this Jul 24, 2020
@fmigneault fmigneault marked this pull request as draft July 24, 2020 04:15
@github-actions github-actions bot added api Something related to the API operations db Issues related to database connection, migration or data models doc Documentation improvements or building problem ui Something related to the UI operations or display labels Jul 24, 2020
This was referenced Jul 24, 2020
Closed
Closed
Closed
@github-actions github-actions bot added the plugin Service plugin label Jul 28, 2020
@github-actions github-actions bot added the ci Something related to code tests, deployment and packaging label Jul 28, 2020
@fmigneault
fix package verison extraction in setup
308c1c8
@fmigneault
add contextual user docs + patch context user resolution when unauthe…
b95b9e4 
…nticated (still needs tests)
@fmigneault
lint doc fix
3cd4f7f
@fmigneault
add test for no-auth user accessing other user details
da16a7a
@fmigneault
fix missing service type when none registered
ba034d1
@fmigneault
fix backward compat of curl command message
17b5423
@fmigneault
patch test cookies
0c35953
@fmigneault
backward compat
59c534a
@fmigneault
improve typing + fix py2 bwcompat args by removing internal arg to fu…
f41ea3f 
…nction
@fmigneault
default disable feature to push service updates to phoenix
19cb344
@fmigneault
fix backport tempdir unittest
117b4a4
@fmigneault
fix bad requirement definition
a9711ef
@fmigneault
python 2.7 & python 3.5 support notes
b101a99
@fmigneault
adjust pip install sys
e82e176
@fmigneault
remove pip use-feature-2020-resolver breaking a lot
64b19ee
@fmigneault
re-add pip 2020-resolver + remove typing install in python 3
c9b423a
@fmigneault
update linters to Python 3.7 with fixes to latest pylint & isort
ca06122
@fmigneault
adjust docker image of adapter with python3 as base magpie
9a8f2f9
@fmigneault
patch warning symbol on remove service
d85347a
dbyrns
dbyrns suggested changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, all my previous comments have been adressed, but I still saw 2 weird behaviors.

magpie/ui/management/views.py Outdated Show resolved Hide resolved
dbyrns
dbyrns approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the fixes. We now have a very good 2.0 Magpie!

@fmigneault fmigneault merged commit dd6ea98 into master Sep 17, 2020
@fmigneault fmigneault deleted the user-scope-views branch September 17, 2020 13:05
@fmigneault fmigneault mentioned this pull request Oct 5, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyrns dbyrns dbyrns approved these changes

@Zvax Zvax Awaiting requested review from Zvax

Assignees

@fmigneault fmigneault

Labels
api Something related to the API operations ci Something related to code tests, deployment and packaging cli Something related to the CLI helpers db Issues related to database connection, migration or data models doc Documentation improvements or building problem plugin Service plugin security New security features or failing AuthN/AuthZ conditions tests Test execution or additional use cases ui Something related to the UI operations or display
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

[BUG] mismatch between documentation and requests
3 participants
@fmigneault @codecov-commenter @dbyrns