Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intersphinx Mapping xarray #955

Merged
merged 3 commits into from
Dec 13, 2021
Merged

intersphinx Mapping xarray #955

merged 3 commits into from
Dec 13, 2021

Conversation

aaronspring
Copy link
Contributor

@aaronspring aaronspring commented Dec 10, 2021 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.
  • bumpversion patch has been called on this branch
  • The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

before
image

after
image

ref pydata/xarray#4279

@coveralls
Copy link

coveralls commented Dec 10, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 90.681% when pulling 5e17705 on aaronspring:patch-2 into eda82c0 on Ouranosinc:master.

@Zeitsperre Zeitsperre self-requested a review December 10, 2021 16:51
@Zeitsperre Zeitsperre added the enhancement New feature or request label Dec 10, 2021
@Zeitsperre Zeitsperre added this to the v0.32 milestone Dec 10, 2021
Zeitsperre
Zeitsperre approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks for the PR!

@Zeitsperre
Copy link
Collaborator

All that's missing is your name on the contributors for this version, and I'll merge it right away.

@Zeitsperre Zeitsperre merged commit ee25c54 into Ouranosinc:master Dec 13, 2021
@aaronspring aaronspring deleted the patch-2 branch December 13, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.32
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronspring @coveralls @Zeitsperre