Skip to content

Commit

Permalink
fix: add NotificationDismissReceiver to `plugin.xml (#38)
Browse files Browse the repository at this point in the history
- The NotificationDismissReceiver declaration was missing in the plugin.xml , which was causing the receiver to not ever be called and as such, no dismissed notifications were being processed by one signal, causing the resurrections of them all

https://outsystemsrd.atlassian.net/browse/RMET-3870
  • Loading branch information
OS-martacarlos authored Nov 26, 2024
1 parent a6ce821 commit 9eac07a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.11.1-OS13]
### Fixes
- Android | Update `plugin.xml` with `NotificationDismissReceiver` declaration (https://outsystemsrd.atlassian.net/browse/RMET-3870).

## [2.11.1-OS12]
### Features

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "2.11.1-OS12",
"version": "2.11.1-OS13",
"name": "onesignal-cordova-plugin",
"cordova_name": "OneSignal Push Notifications",
"description": "OneSignal is a high volume Push Notification service for mobile apps. In addition to basic notification delivery, OneSignal also provides tools to localize, target, schedule, and automate notifications that you send.",
Expand Down
3 changes: 2 additions & 1 deletion plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="onesignal-cordova-plugin"
version="2.11.1-OS12">
version="2.11.1-OS13">

<name>OneSignal Push Notifications</name>
<author>Josh Kasten, Bradley Hesse, Rodrigo Gomez-Palacio</author>
Expand Down Expand Up @@ -54,6 +54,7 @@
<category android:name="$PACKAGE_NAME" />
</intent-filter>
</receiver>
<receiver android:exported="false" android:name="com.onesignal.NotificationDismissReceiver" />
</config-file>

<source-file src="src/android/com/plugin/gcm/OneSignalPush.java" target-dir="src/com/plugin/gcm/" />
Expand Down

0 comments on commit 9eac07a

Please sign in to comment.