RMET-3477 :: OutSystems Wrapper :: Add OneSignal Plugin Manager #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMET-3005 :: Release
- adds code specific to outsystems lifecycle aka one signal plugin manager - adds the code that will be in outsystems' wrapper javascript nodes https://outsystemsrd.atlassian.net/browse/RMET-3477
OS-martacarlos
requested review from
ItsChaceD,
IT-MikeS,
alexgerardojacinto and
OS-ricardomoreirasilva
and removed request for
a team
OS-ricardomoreirasilva
approved these changes
Jun 19, 2024
- having the object creation was leading to bugs on the OutSystems side, as it wasn't a singleton, new instances of the object kept being created - fixes unit tests accordingly https://outsystemsrd.atlassian.net/browse/RMET-3477
IT-MikeS
approved these changes
Jun 20, 2024
OS-martacarlos
force-pushed
the
feat/RMET-3477/adds-manager
branch
3 times, most recently
from
6b41192 to
a8919f0
Compare
OS-martacarlos
force-pushed
the
feat/RMET-3477/adds-manager
branch
from
a8919f0 to
5d9efc8
Compare
|
alexgerardojacinto
approved these changes
Jun 21, 2024
OS-ricardomoreirasilva
approved these changes
Jun 21, 2024
alexgerardojacinto
added a commit
that referenced
this pull request
Sep 17, 2024
* RMET-3477 :: OutSystems Wrapper :: Add OneSignal Plugin Manager (#35) - adds code specific to outsystems lifecycle aka one signal plugin manager - adds the code that will be in outsystems wrapper's javascript nodes - add sonar cloud integration for typescript files https://outsystemsrd.atlassian.net/browse/RMET-3477 * RMET-3608 OneSignal-Cordova-SDK - Update dependency to FCM Android SDK (#36) * feat: update FB Messaging Android library References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * feat: use Firebase BOM to get FB Cloud Messaging lib Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * Revert "feat: use Firebase BOM to get FB Cloud Messaging lib" This reverts commit a3e6be3. * fix: add necessary Firebase library for OneSignal to work with latest version of Cloud Messaging Context: https://firebase.google.com/support/release-notes/android?_gl=1*d5zec9*_up*MQ..*_ga*OTY5NjA2OTg5LjE3MjYwNTUwMDE.*_ga_CW55HF8NVT*MTcyNjA1NTAwMS4xLjAuMTcyNjA1NTAwMS4wLjAuMA..#messaging_v22-0-0 References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore: update changelog References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore(release): raise to version 2.11.1-OS12 References: https://outsystemsrd.atlassian.net/browse/RMET-3608 --------- Co-authored-by: Marta Carlos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds code that until now only existed in the OutSystems Wrapper. This means:
Context
https://outsystemsrd.atlassian.net/browse/RMET-3477
Type of changes
Platforms affected
Tests
As we're not admins of this repo, SonarCloud is not yet configured. As to not block the task, here are the unit tests results:
Checklist
RNMT-XXXX <title>