Custom Eye Travelers #1031
Merged
Custom Eye Travelers #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-New-Horizons/new-horizons into hawkbar-eye-sequence
…-New-Horizons/new-horizons into hawkbar-eye-sequence
…-New-Horizons/new-horizons into hawkbar-eye-sequence
…-New-Horizons/new-horizons into hawkbar-eye-sequence
Bwc9876
requested changes
Feb 7, 2025
Bwc9876
approved these changes
Feb 7, 2025
xen-42
requested changes
Feb 8, 2025
|
|
||
| namespace NewHorizons.Components.EyeOfTheUniverse | ||
| { | ||
| public class InstrumentZone : MonoBehaviour |
There was a problem hiding this comment.
Why does this exist? Probably for a good reason so can you comment in the class why
| @@ -691,6 +691,11 @@ private static GameObject SharedGenerateBody(NewHorizonsBody body, GameObject go | |||
| atmosphere = AtmosphereBuilder.Make(go, sector, body.Config.Atmosphere, surfaceSize).GetComponentInChildren<LODGroup>(); | |||
| } | |||
|
|
|||
| if (body.Config.EyeOfTheUniverse != null) | |||
There was a problem hiding this comment.
Doesn't seem to be anything stopping this being called from outside the eye scene, so we should have that. When validating configs we should log errors if this is not null and the system isnt set to EyeOfTheUniverse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major features
EyeOfTheUniversemodule to the planet body config for features specific to the Eye of the Universe scene.eyeTravelers,quantumInstruments, andinstrumentZonesto theEyeOfTheUniversemodule to support adding new travelers and instrument 'puzzles' to the Eye of the Universe in a compatibility-minded way.Improvements