Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix NPM package creation errors #535 #536

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

valarnin
Copy link
Collaborator

@valarnin valarnin commented Dec 8, 2024

#271 removed some paths from the default tsconfig, which causes issues when building the npm package.

This PR adds an npm package-specific tsconfig file to resolve the issue.

@github-actions github-actions bot added ci /.github/ needs-review Awaiting review labels Dec 8, 2024
@valarnin valarnin linked an issue Dec 8, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@MaikoTan MaikoTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

And test and user folders are also required in the npm package?

@github-actions github-actions bot removed the needs-review Awaiting review label Dec 8, 2024
@valarnin valarnin merged commit 234ea9f into OverlayPlugin:main Dec 8, 2024
9 checks passed
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci /.github/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM package creation errors
2 participants