-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure SWXSOC_MISSION
Env Var on init of Instrument Package
#11
Conversation
* Test env in init * Remove env variables from workflows * Test env in init * Lint * Linting * Linting * Fix syntax in test-in-container workflow * Fix syntax in test-in-container workflow * Lint once more -_- * Fix flake error after black linting * update workflow --------- Co-authored-by: Damian Barrous-Dume <[email protected]>
The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11330499568/artifacts/2053885031 |
The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11330702310/artifacts/2053939193 |
The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11361591744/artifacts/2062148599 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 61.28% 55.10% -6.19%
==========================================
Files 10 9 -1
Lines 545 441 -104
==========================================
- Hits 334 243 -91
+ Misses 211 198 -13 ☔ View full report in Codecov by Sentry. |
The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11361684089/artifacts/2062174020 |
The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11361771598/artifacts/2062197651 |
In this PR, we configure the environmental variable
SWXSOC_MISSION
on initialization or import of the instrument package so that theswxsoc
package can use the right mission configuration (in this casepadre
) without the need for the user to set-up a custom configuration or set the environmental variable themselves.It doesn't overwrite if the
SWXSOC_MISSION
environmental variable already exists, so that users can still change the configured mission if they'd like within their development environment.swxsoc
mission configuration file maintained by us for the missions we support: https://github.com/swxsoc/swxsoc/blob/main/swxsoc/data/config.ymlMore info on how to customize the
swxsoc
core package configuration can be found here: https://swxsoc.readthedocs.io/en/latest/user-guide/customization.htmlOther fixes in this PR:
tmp