Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure SWXSOC_MISSION Env Var on init of Instrument Package #11

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

dbarrous
Copy link
Contributor

@dbarrous dbarrous commented Oct 14, 2024

In this PR, we configure the environmental variable SWXSOC_MISSION on initialization or import of the instrument package so that the swxsoc package can use the right mission configuration (in this case padre) without the need for the user to set-up a custom configuration or set the environmental variable themselves.

It doesn't overwrite if the SWXSOC_MISSION environmental variable already exists, so that users can still change the configured mission if they'd like within their development environment.

swxsoc mission configuration file maintained by us for the missions we support: https://github.com/swxsoc/swxsoc/blob/main/swxsoc/data/config.yml

More info on how to customize the swxsoc core package configuration can be found here: https://swxsoc.readthedocs.io/en/latest/user-guide/customization.html

Other fixes in this PR:

  • Fixes a broken workflow which runs tests within the container
  • Also updates a workflow so that it processes the file to the correct directory within the container tmp
  • Updates Codecov report

* Test env in init

* Remove env variables from workflows

* Test env in init

* Lint

* Linting

* Linting

* Fix syntax in test-in-container workflow

* Fix syntax in test-in-container workflow

* Lint once more -_-

* Fix flake error after black linting

* update workflow

---------

Co-authored-by: Damian Barrous-Dume <[email protected]>
Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11330499568/artifacts/2053885031

Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11330702310/artifacts/2053939193

@dbarrous dbarrous requested a review from ehsteve October 14, 2024 15:36
Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11361591744/artifacts/2062148599

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.10%. Comparing base (5b8f363) to head (cb4f231).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   61.28%   55.10%   -6.19%     
==========================================
  Files          10        9       -1     
  Lines         545      441     -104     
==========================================
- Hits          334      243      -91     
+ Misses        211      198      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11361684089/artifacts/2062174020

Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11361771598/artifacts/2062197651

@ehsteve ehsteve merged commit 0b9c78a into PADRESat:main Nov 5, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants