Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fits meta #12

Merged
merged 22 commits into from
Nov 18, 2024
Merged

Fits meta #12

merged 22 commits into from
Nov 18, 2024

Conversation

ehsteve
Copy link
Member

@ehsteve ehsteve commented Oct 17, 2024

This adds the ability to create fits files for all types of data packets. It also makes a first cut adding appropriate metadata to the files.

@ehsteve ehsteve marked this pull request as draft October 23, 2024 18:29
This section describes the organization the level 0 FITS files.
Level 0 fits files generally include the unconverted data from the raw binary files of ccsds packets.
The purpose of these files is to provide the raw data from the raw binary files in a more convinient form for analysis.
It also provides metadata information which summary the data in the file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "summary" to "summarizes".

The primary HDU contains no data and is only used for metadata.
The two other HDUs are named `SCI` and `PKT`.
`SCI` includes the event data while `PKT` includes the packet data.
Each data packet may include one of more event therefore there is a one to many relationship between them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by this. Should it say "Each data packet may include one or more events, therefore there is a one to many..."?

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 68.90756% with 74 lines in your changes missing coverage. Please review.

Project coverage is 56.30%. Comparing base (0b9c78a) to head (0bb8dc1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
padre_meddea/calibration/calibration.py 38.98% 36 Missing ⚠️
padre_meddea/io/file_tools.py 65.00% 35 Missing ⚠️
padre_meddea/io/fits_tools.py 93.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   55.10%   56.30%   +1.20%     
==========================================
  Files           9       10       +1     
  Lines         441      595     +154     
==========================================
+ Hits          243      335      +92     
- Misses        198      260      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11897890274/artifacts/2202974458

Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11898003221/artifacts/2203011293

Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11898076579/artifacts/2203032657

Copy link

The processed files are available as an artifact: https://github.com/PADRESat/padre_meddea/actions/runs/11900435767/artifacts/2203766993

@ehsteve ehsteve marked this pull request as ready for review November 18, 2024 20:31
@ehsteve ehsteve merged commit c83669f into PADRESat:main Nov 18, 2024
13 checks passed
@ehsteve ehsteve deleted the fits_meta branch November 18, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants