Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSError(30) in Calibration, Add Calibration Workflow, Integrate SWxSOC Package, and Fix Linting Issues #4

Merged
merged 24 commits into from
Aug 8, 2024

Conversation

dbarrous
Copy link
Contributor

@dbarrous dbarrous commented Jul 30, 2024

This pull request includes the following changes and improvements:

  • Fixes OSError(30) in Lambda Function: Modifies the calibration function to write new files to a temporary directory. This prevents the OSError(30, 'Read-only file system') error when performing HDUList.writeto in the Lambda function.

  • Adds Calibration Workflow: Implements a new calibration workflow that runs the calibration process and comments with a link to the processed artifacts. Adds a test event for the workflow to utilize. Includes a correctly named test bin file for the workflow.

  • Integrates SWxSOC Core Package: Adds the SWxSOC core package as a dependency for creating and parsing filenames. Removes unused duplicate functions and tests for utils, updating the tests and code to use functions from the SWxSOC package.

  • Fixes Linting Issues: Resolves various linting issues across the codebase.

@dbarrous
Copy link
Contributor Author

dbarrous commented Jul 30, 2024

This fix is able to produce the file padre_meddea_l1test_eventlist_20240327T134616_v0.1.0.fits, @ehsteve Is it supposed to be l0 or l1? I can change it back to the latter if needed.

@dbarrous dbarrous marked this pull request as ready for review July 30, 2024 17:26
@dbarrous dbarrous requested a review from ehsteve July 30, 2024 17:26
@dbarrous dbarrous changed the title Fix OSError Directory write issue Fix OSError(30) in Calibration, Add Calibration Workflow, Integrate SWxSOC Package, and Fix Linting Issues Jul 31, 2024
@dbarrous
Copy link
Contributor Author

Since this isn't a pull_request_target event with proper write permissions since the workflow is being added in this PR, it won't comment. But will comment with artifact link on consequent PRs. Here is the link of the generated artifacts: https://github.com/PADRESat/padre_meddea/actions/runs/10177912394/artifacts/1759407468

padre_meddea/tests/test_data/test_meddea_event.json Outdated Show resolved Hide resolved
padre_meddea/util/config.py Outdated Show resolved Hide resolved
padre_meddea/util/util.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
padre_meddea/tests/test_util_util.py Outdated Show resolved Hide resolved
padre_meddea/util/config.py Outdated Show resolved Hide resolved
padre_meddea/util/util.py Outdated Show resolved Hide resolved
Copy link

@Alrobbertz Alrobbertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbarrous dbarrous merged commit d0023e3 into PADRESat:main Aug 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants