Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message if a ReactionMethod fails at runtime #140

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

sjdaines
Copy link
Member

Catch runtime exception if a ReactionMethod fails, and print an error message containing tje name of the failed Reaction as in the YAML config file. This is helpful if there are multiple instances of the same Reaction and it's not clear which one is failing.

NB: requires 'generated_dispatch=false' argument to PALEOmodel.initialize!

This is the first part of #139, without the addition of exception handling to the @generated functions which slows down compile time (by ~20% or so).

Catch runtime exception if a ReactionMethod fails, and print an
error message containing tje name of the failed Reaction as in the YAML
config file. This is helpful if there are multiple instances of the same Reaction
and it's not clear which one is failing.

NB: requires 'generated_dispatch=false' argument to PALEOmodel.initialize!
@sjdaines sjdaines merged commit 98121b5 into main Nov 29, 2024
3 checks passed
@sjdaines sjdaines deleted the method_error_improvement_minimal branch November 29, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant