Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia 1.11 public keyword #155

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Add Julia 1.11 public keyword #155

merged 2 commits into from
Jan 14, 2025

Conversation

sjdaines
Copy link
Member

@sjdaines sjdaines commented Jan 14, 2025

  • define public API as list of public structs, methods etc in PALEOboxes.jl
  • move deprecated methods to new deprecated.jl file
  • remove unused parameters Vector in ReactionBase (duplicates pars::ParametersTuple field) and replace add_par method with and error message (only used within PALEOboxes.jl)

Use @public macro from https://discourse.julialang.org/t/is-compat-jl-worth-it-for-the-public-keyword/119041/22 to maintain backwards compatibility with earlier Julia versions.

- define public API as list of public methods etc in PALEOboxes.jl
- move deprecated methods to new deprecated.jl file
- remove unused parameters Vector in ReactionBase (duplicates pars::ParametersTuple field)
  and replace add_par method with and error message (only used within PALEOboxes.jl)
@sjdaines sjdaines merged commit 711ae0a into main Jan 14, 2025
3 checks passed
@sjdaines sjdaines deleted the public_keyword branch January 14, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant