Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convert method for IsotopeLinear #28

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

sjdaines
Copy link
Member

This is needed for StructArrays v0.6.8 https://github.com/JuliaArrays/StructArrays.jl/releases/tag/v0.6.8
See
JuliaArrays/StructArrays.jl#131
JuliaArrays/StructArrays.jl#216

It's not clear to me whether the behaviour of StructArrays.jl is now correct (so this is a PALEOboxes.jl fix that
used to not matter) or whether this is a workaround for a newly introduced StructArrays.jl issue

This is needed for StructArrays v0.6.8 https://github.com/JuliaArrays/StructArrays.jl/releases/tag/v0.6.8
See
JuliaArrays/StructArrays.jl#131
JuliaArrays/StructArrays.jl#216

It's not clear to me whether the behaviour of StructArrays.jl is now correct (so this is a PALEOboxes.jl fix that
used to not matter) or whether this is a workaround for a newly introduced StructArrays.jl issue
@sjdaines sjdaines merged commit 507c65c into main May 27, 2022
@sjdaines sjdaines deleted the convert_IsotopeLinear branch May 27, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant