Dimensions and coordinates #85
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PALEOtoolkit/PALEOmodel.jl#48 Initial test updating NamedDimension so that `coords` is just a vector of names of preferred coordinates. NB: shows that there are no tests for get_region in this package.
sjdaines
added a commit
to sjdaines/PALEOmodel.jl
that referenced
this pull request
May 5, 2023
See PALEOtoolkit#48 PALEOtoolkit/PALEOboxes.jl#85 - Generalize FieldArray - move get_region and coordinate manipulation code from PALEOboxes.jl - rename FixedCoord -> RecordCoord as now only used by FieldRecord (and should be used by OutputWriter) TODO this currently allows a model (only the black sea config tested) to run and store output, but the FieldRecord etc (and surely FieldArray and plotting) does not work. Stop at this point as this illustrates a review of the data model for internal data storage (at least) is needed. Which requires implementing a standardised stable output format on disk first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PALEOtoolkit/PALEOmodel.jl#48
Initial test updating NamedDimension so that
coordsis just a vector of names of preferred coordinates.NB: shows that there are no tests for get_region in this package.