fix(dataverse): implement fix for data-verse upload crash #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmurugan-fzj
commented
Nov 14, 2024
jmurugan-fzj
commented
- Removed signal disconnect calls which leads to segmentation fault with the latest version of pyside6.
- Connected finish and cancel signals with respective slots via DirectConnection for the slots to be executed in the calling thread itself(just flipping the respective flags used inside the threads).
…ith the latest version of pyside6. - Connected finish and cancel signals with respective slots via DirectConnection for the slots to be executed in the calling thread itself(just flipping the respective flags used inside the threads).
|
@SteffenBrinckmann Could you please review this PR, this is the issue which I had discussed today. |
SteffenBrinckmann
approved these changes
Nov 14, 2024
jmurugan-fzj
deleted the
365-data-verse-parallel-uploads-throws-segmentation-fault-and-crashes-pasta-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.