fix(smart-contracts): refactor contract to address pfc comments #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Instantiate
to a separate function to be reused onSettleAuction
and not repeat code.auction.<counter>
to have some context when checking wallet balances.cw_ownable
.ExitPool
now checks if the contract has the funds locked and only allows people exiting the pool of they are not. Funds are locked on the first bid and unlocked when settling the auction.Instantiate
now needs to send some native tokens that will stay in the contract for creating new denoms. The minimum balance is then saved intoConfig