Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smart-contracts): refactor contract to address pfc comments #3

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

nseguias
Copy link
Collaborator

This PR does the following:

  1. Moves the start bid process from Instantiate to a separate function to be reused on SettleAuction and not repeat code.
  2. Factory subdenom has now a more meaningful name auction.<counter> to have some context when checking wallet balances.
  3. Modifies the way the contract owner is updated, using cw_ownable.
  4. Changes the way it adds or removes whitelisted addresses to prevent overriding the list of whitelisted addresses by mistake.
  5. ExitPool now checks if the contract has the funds locked and only allows people exiting the pool of they are not. Funds are locked on the first bid and unlocked when settling the auction.
  6. Bidding balance tracks the amount of native funds that can be used for bidding, and makes sure there are always funds available for creating a new denom.
  7. Instantiate now needs to send some native tokens that will stay in the contract for creating new denoms. The minimum balance is then saved into Config

@nseguias nseguias requested a review from kerber0x March 15, 2024 16:37
Copy link

codecov bot commented Mar 15, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@PFC-developer PFC-developer merged commit 57e8a1e into main Mar 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants