Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a blog post about event in xi'an #2

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

jzhang533
Copy link
Contributor

No description provided.

@jzhang533
Copy link
Contributor Author

@luotao1 @Ligoml @SigureMo please have a look on this post.

Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SigureMo SigureMo Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 可以运行 pnpm fmt 来对代码进行格式化~
  2. 可以将每篇 blog 放在同一个目录中,避免将来不好管理,比如本篇统一放在 src/public/images/xian-event/ 下~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放到子目录下的话,还需要在index.md里加index吗?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以将每篇 blog 放在同一个目录中

啊 刚刚表述不太清楚:joy:,是每篇 blog 的图片放在同一个目录中,博客统一直接放在 posts 下

路径也写错了,应该是 src/public/images/xian-event/

比如第一张图片在 src/public/images/xian-event/xian-event-01.jpg

引入时使用:

![xian-event-01](../public/images/xian-event/xian-event-01.jpg)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好,明白了

@jzhang533
Copy link
Contributor Author

@SigureMo 图片路径好像还是有点问题:

Could not resolve "./../public/images/xian-event/xian-event-01.jpg" from "src/posts/xian-event.md"

@SigureMo
Copy link
Collaborator

@SigureMo 图片路径好像还是有点问题:

我来调整下~

@SigureMo SigureMo enabled auto-merge October 25, 2023 06:48
@SigureMo SigureMo added this pull request to the merge queue Oct 25, 2023
Merged via the queue into PFCCLab:main with commit 96e2456 Oct 25, 2023
@jzhang533 jzhang533 deleted the xian-event branch October 25, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants