Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make upgrade and addnotes idempotent #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wolfgangwalther
Copy link

This allows running the setnotes.pl and update_personality.pl scripts in the client-code repo repeatedly without causing multiple changes / rows on the server-side.

This has the following advantages:

  • It fixes a theoretical problem when the client sends the request successfully, but doesn't receive the response due to a network error - and then tries the same thing again, ending up with a duplicate row for the os/compiler version.
  • It allows automating the update of os / compiler versions (and notes, too, in case they contain any version information). This can be as simple as a script run via the same cron job as the build script itself - checking for the current os and compiler version and sending those before each run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant