Merge pull request #485 from PHOENIXCONTACT/fix/dead-end-validation

Port: Allow DeadEndValidator to pass on workplans with disconnected connectors
PHOENIXCONTACT · Nov 21, 2024 · a6eff35 · a6eff35
2 parents 792247f + 6baccdb
commit a6eff35
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/Moryx/Workflows/Validation/DeadEndValidator.cs b/src/Moryx/Workflows/Validation/DeadEndValidator.cs
@@ -28,6 +28,10 @@ public bool Validate(IWorkplan workplan, ICollection<ValidationError> errors)
                 if(connector.Classification.HasFlag(NodeClassification.Exit))
                     continue;
 
+                //  or if it is not used as an output anywhere and is not a start connector
+                if (!workplan.Steps.Any(step => step.Outputs.Contains(connector)) && !connector.Classification.HasFlag(NodeClassification.Entry))
+                    continue;
+
                 errors.Add(new DeadEndValidationError(connector.Id));
             }
             return errors.Count == 0;