Mixed usage of Type.Name and FullName caused UI mismatch

PHOENIXCONTACT · Feb 20, 2024 · fca925e · fca925e
1 parent 4411531
commit fca925e
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/Moryx.AbstractionLayer.Products.Endpoints/ProductConverter.cs b/src/Moryx.AbstractionLayer.Products.Endpoints/ProductConverter.cs
@@ -27,16 +27,22 @@ public ProductConverter(IProductManagement productManagement)
         {
             _productManagement = productManagement;
         }
+
         public ProductDefinitionModel ConvertProductType(Type productType)
         {
+            var baseType = productType.BaseType;
+            var baseTypeName = baseType == typeof(ProductType)
+                ? string.Empty : baseType.FullName;
+
             return new()
             {
                 Name = productType.FullName,
                 DisplayName = productType.GetDisplayName() ?? productType.Name,
-                BaseDefinition = productType.BaseType?.Name,
+                BaseDefinition = baseTypeName,
                 Properties = EntryConvert.EncodeClass(productType, ProductSerialization)
             };
         }
+
         public RecipeDefinitionModel ConvertRecipeType(Type recipeType)
         {
             return new()