If you put a EntrySerialize over a Resource itself and also use it in one of the properties, there will be a StackOverflow Exception

[MathoMathiasCamara]

• Added a check to ignore self reference properties
• Added a check to ignore EntrySerializeAttribute from overriding the attribute on the base class.

[MarisaGoergen]

The UI shouldn't show even the resource graph if you put entry serialize on the class.

[MarisaGoergen]

Why don't we just declare that it's not allowed to use EntrySerialize over classes? @Toxantron @dbeuchler

[dbeuchler]

Why don't we just declare that it's not allowed to use EntrySerialize over classes? @Toxantron @dbeuchler

I have not read the full merge request but: the EntrySerializeAttribute was developed to define it on classes, methods and properties. If you write it on a class, the rules will be applied for the whole class except the member is modified by the attribute itself. You can also declare "Never" on a the class and just add members explicitly.

See line 123: https://github.com/PHOENIXCONTACT/MORYX-Framework/blob/dev/src/Moryx/Serialization/EntrySerializeSerialization.cs

As I remember: The Resource-Type declares EntrySerialize(Never). This should not be overridden by the developer. https://github.com/PHOENIXCONTACT/MORYX-Framework/blob/dev/src/Moryx.AbstractionLayer/Resources/Resource.cs

[Toxantron]

As I remember: The Resource-Type declares EntrySerialize(Never). This should not be overridden by the developer.

We should defenitly prohibit the override. For MORYX 8 we could even forbid it on the level of attribute declaration. There is an option "AllowMultiple = false".

[Toxantron]

Please keep in mind, there is a dedicated EntrySerializeSerialization. We should not change the behavior of the DefaultSerialization.

Instead we should isolate this either as a double declaration check in EntrySerializeSerialization and just checking for EntrySerizalize in ResourceSerialization.

[Toxantron]

Instead of changing the behavior, just improve the code that reads the class property. This should give preference to the base class declaration over the incorrect override.

For MORYX 8 I suggest we declare the attribute to prohibit duplicate declaration.

Edit: A definition on derived types can not be prohibited. That means we just change the code to give preference to the base class.

Changes already applied