Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DisposedObjectException in DatabaseController #349

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix DisposedObjectException in DatabaseController #349

merged 2 commits into from
Oct 27, 2023

Conversation

seveneleven
Copy link
Contributor

@seveneleven seveneleven commented Oct 25, 2023 •
edited
Loading

Not awaiting the setup.Execute call in ModelSetupExecutor.Execute lead to
DisposedObjectException

@seveneleven seveneleven self-assigned this Oct 25, 2023
@seveneleven seveneleven added the bug Something isn't working label Oct 25, 2023
@seveneleven seveneleven force-pushed the bugfix/db-controller-disposed-object-exception branch from 5a07019 to 4b940d4 Compare October 25, 2023 08:58
1nf0rmagician
1nf0rmagician reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@1nf0rmagician 1nf0rmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An please provide a description for the MR and make the title a normal sentance 😊

src/Moryx.AbstractionLayer.TestTools/InMemoryUnitOfWorkFactoryBuilder.cs Outdated Show resolved Hide resolved
src/Moryx.Model.Sqlite/SqliteDbContextManager.cs Show resolved Hide resolved
src/Moryx.Model/ModelSetupExecutor.cs Show resolved Hide resolved
src/Moryx.Runtime.Endpoints/Databases/Endpoint/DatabaseController.cs Show resolved Hide resolved
@seveneleven seveneleven changed the title Bugfix/db controller disposed object exception Fix DisposedObjectException in DatabaseController Oct 26, 2023
@seveneleven
Add Test to prove DisposedObjectException in DatabaseController
225daac 
* `ModelSetupExecutor` is public to be used by `IDbContextManager`
  implementations in different packages
* Split up DbContextManager and factory creation in `InMemoryUnitOfWorkFactoryBuilder`
@seveneleven
Fix DatabaseController/ModelSetupExecutor by awaiting Execute()
cfaf02e 
Not awaiting the `setup.Execute` call in `ModelSetupExecutor.Execute`.
Otherwise the UOWs DbContext would get disposed before `setup.Execute` had
finished and thus result in a DisposedObjectException.
@seveneleven seveneleven force-pushed the bugfix/db-controller-disposed-object-exception branch from 4b940d4 to cfaf02e Compare October 26, 2023 07:22
@Toxantron Toxantron added this to the Framework 6.2.5 milestone Oct 26, 2023
@seveneleven seveneleven merged commit 4787f7c into dev Oct 27, 2023
@seveneleven seveneleven deleted the bugfix/db-controller-disposed-object-exception branch October 27, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1nf0rmagician 1nf0rmagician 1nf0rmagician approved these changes

@Toxantron Toxantron Awaiting requested review from Toxantron

Assignees

@seveneleven seveneleven

Labels
bug Something isn't working
Projects
None yet
Milestone
Framework 6.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@seveneleven @Toxantron @1nf0rmagician