Implement new .NET8 specific attributes to entry-format validation #516
Conversation
There was a problem hiding this comment.
Two additional remarks
- Please update the documentation. Fell free to not only add your new additions but also correct any issues you encountered when using the documentation to understand the Entry concept. As I told you at the beginning, it would be nice if the next person getting into it could understand what it is and what it can be used for without to much additional help from us personally.
- Did you decide against the new
Base64Stringvalidation attribute for a specific reason? Coincidently, we could probably make good use of that validation attribute with the new File System we want to provide😬
| public isRequired: boolean; | ||
| public isPassword: boolean; | ||
| public deniedValue: string[]; | ||
| public allowedValue: string[]; |
There was a problem hiding this comment.
For this there is already a possible Values attribute. We should make the generated entry equivalent between using AllowedValues and our Custom PossibleValues
| } | ||
|
|
||
| /// <see cref="ICustomSerialization"/> | ||
| public virtual EntryValidation CreateValidation(Type memberType, ICustomAttributeProvider attributeProvider) |
There was a problem hiding this comment.
I would have expected changes in this method, might be however that they are just hidden behind the encoding change and I overlooked them
There was a problem hiding this comment.
Yes, I actually did edit this method as well, but I have no idea where the changes are now... so I'll do it again.
There was a problem hiding this comment.
As you know, the command center is a web project building on your changes and hence it is not an angular project it unfortunately does not share the entry editor with our commercial web projects.
Therefore, it would be good if you would check that the new validation options are used in the UI, i.e. search the place where the other validation (errors) are depicted and add the new ones there too.
|
One more comment to add: Please check this site, it explains the two different attributes to validate collection length and string length. I think it would be alright to share the field in the validation class, as we also have the |
No description provided.