-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add highlight methods to search and search builder #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
933a1f1
to
2a85aaa
Compare
public function getSearcher(): SearcherInterface | ||
{ | ||
return $this->searcher; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO need to check why I exposed this in #483
ae6fd23
to
6c232e3
Compare
fa5dc75
to
f9ac29f
Compare
3599dc6
to
db55289
Compare
db55289
to
b8911fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Adapter: Algolia
Algolia Adapter related issue
Adapter: Elasticsearch
Elasticsearch Adapter releated issue
Adapter: Loupe
Loupe Adapter related issue
Adapter: Meilisearch
Meilisearch Adapter related issue
Adapter: Memory
Memory Adapter related issue
Adapter: Opensearch
Opensearch Adapter related issue
Adapter: RediSearch
RediSearch Adapter related issue
Adapter: Solr
Solr Adapter related issue
Adapter: Typesense
Typesense Adapter related issue
features
New feature or request
help wanted
Extra attention is needed
SEAL Core
Seal Core related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the core highlight methods for the highlighting search results:
See also #343
TODO implementation
testSearchConditionWithHighlight
toAbstractSearcherTestCase
: Add highlight implementation for memory adapter #351fixes #343