Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Php Attributes Rather than Annotations for PhpUnit #4239

Merged
merged 1 commit into from
Nov 26, 2024

Commits on Nov 24, 2024

  1. Use Php Attributes Rather than Annotations for PhpUnit

    With PhpUnit 10 came the ability to use Php attributes rather than doc-block annotations for things like "data provider". PhpUnit 11 deprecates the use of annotations, and PhpUnit 12 will not not permit their use. Since PhpUnit 11 requires Php8.2+, we cannot adopt it as long as we support Php8.1, which will continue to be the case for some time. However, there is no penalty for early adoption.
    
    Php-cs-fixer can use:
    ```
    'php_unit_attributes' => ['keep_annotations' => false],
    ```
    This allows us to run `composer fix` to automate all the needed changes. No manual changes were needed for any of the test members.
    
    With this change, PhpUnit 9 can no longer be used with the test suite. File composer.json is updated to reflect that reality, and phpunit9.xml.dist, which has been supplied in case anyone needed to use PhpUnit 9, is no longer required, and is thus deleted. For now, PhpUnit 11 is not being added as a possibility.
    
    No source code is changed in this PR.
    oleibman committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    d647fe7 View commit details
    Browse the repository at this point in the history