Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance vue #375

Open
wants to merge 78 commits into
base: master
Choose a base branch
from
Open

Governance vue #375

wants to merge 78 commits into from

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Aug 14, 2024

Abstract

This PR ports the Governance and Masternode tab in vue, massively simplifing the render logic.

TODO

  • Wait for UI Redesign #372 to be merged
  • Create proposal
  • Figure out when to update to fetch updates from the RPC node
  • Check mobile page
  • Clean up
  • Unit tests

Testing

  • Check the entirety of the masternode page
  • Check the entirety of governance page, including proposals

@Duddino Duddino self-assigned this Aug 14, 2024
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 215a3b1
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6745cdbec70d620008cacdfe
😎 Deploy Preview https://deploy-preview-375--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masternode collateral creation seems to be reversed:

It tries to create the transaction when the wallet is locked (thus throwing the error cannot sign with a view only wallet)

It tries to setMasterkey when the wallet is already unlocked (hence throwing the error a spending key is already loaded)

@JSKitty
Copy link
Member

JSKitty commented Nov 4, 2024

Very minor design consistency change: the voting buttons are not the same size, "Yes" is smaller than "No".

Prod:
image

PR:
image

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When creating the 10kPIVs masternode tx, the tab "Your Masternode Private Key..." doesnt get closed when pressing the X

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening MPW getProposals throw errors

mpw.js:sourcemap:104538 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'filter')
    at Masternode.getProposals (mpw.js:sourcemap:104538:41)
    at async fetchProposals (mpw.js:sourcemap:67700:26)

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to successfully create a masternode, but there are two issues:
Last seen time is wrong;
When I try to vote a proposal I get the following error

index.js:159 Uncaught (in promise) TypeError: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type object
    at from (index.js:159:1)
    at __webpack_modules__../node_modules/buffer/index.js.Buffer.from (index.js:174:1)
    at hexToBytes (utils.js:9:18)
    at Proxy.getSignedVoteMessage (masternode.js:371:26)
    at Proxy.vote (masternode.js:434:1)
    at vote (Governance.vue:178:47)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants