-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance vue #375
base: master
Are you sure you want to change the base?
Governance vue #375
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7fcfcec
to
95b2399
Compare
e2c3925
to
c17d5f7
Compare
Split BudgetAllocated and MonthlyBudget components Fix the render for mobile
Fixed some inconsistencies found when testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
masternode collateral creation seems to be reversed:
It tries to create the transaction when the wallet is locked (thus throwing the error cannot sign with a view only wallet)
It tries to setMasterkey when the wallet is already unlocked (hence throwing the error a spending key is already loaded)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When creating the 10kPIVs masternode tx, the tab "Your Masternode Private Key..." doesnt get closed when pressing the X
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When opening MPW getProposals throw errors
mpw.js:sourcemap:104538 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'filter')
at Masternode.getProposals (mpw.js:sourcemap:104538:41)
at async fetchProposals (mpw.js:sourcemap:67700:26)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to successfully create a masternode, but there are two issues:
Last seen time is wrong;
When I try to vote a proposal I get the following error
index.js:159 Uncaught (in promise) TypeError: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type object
at from (index.js:159:1)
at __webpack_modules__../node_modules/buffer/index.js.Buffer.from (index.js:174:1)
at hexToBytes (utils.js:9:18)
at Proxy.getSignedVoteMessage (masternode.js:371:26)
at Proxy.vote (masternode.js:434:1)
at vote (Governance.vue:178:47)
Abstract
This PR ports the Governance and Masternode tab in vue, massively simplifing the render logic.
TODO
Testing