add function to check that all proposals are paid

src/budget/budgetmanager.cpp

@@ -758,6 +758,21 @@ TrxValidationStatus CBudgetManager::IsTransactionValid(const CTransaction& txNew
     return fThreshold ? TrxValidationStatus::InValid : TrxValidationStatus::VoteThreshold;
 }
 
+bool CBudgetManager::IsValidSuperBlockTx(const CTransaction& txNew, int nBlockHeight) const
+{
+    assert(Params().GetConsensus().IsSuperBlock(nBlockHeight));
+
+    int nFivePercent = mnodeman.CountEnabled() / 20;
+
+    const auto highest = GetBudgetWithHighestVoteCount(nBlockHeight);
+    const CFinalizedBudget* pfb = highest.m_budget_fin;
+    if (pfb == nullptr || highest.m_vote_count <= nFivePercent) {
+        // No finalization or not enough votes. Nothing to check.
+        return true;
+    }
+    return pfb->AllBudgetsPaid(txNew);
+}
+
 std::vector<CBudgetProposal*> CBudgetManager::GetAllProposalsOrdered()
 {
     LOCK(cs_proposals);

src/budget/budgetmanager.h

@@ -146,7 +146,9 @@ class CBudgetManager : public CValidationInterface
 
     bool UpdateProposal(const CBudgetVote& vote, CNode* pfrom, std::string& strError);
     bool UpdateFinalizedBudget(const CFinalizedBudgetVote& vote, CNode* pfrom, std::string& strError);
-    TrxValidationStatus IsTransactionValid(const CTransaction& txNew, const uint256& nBlockHash, int nBlockHeight) const;
+    TrxValidationStatus IsTransactionValid(const CTransaction& txNew, const uint256& nBlockHash, int nBlockHeight) const; // legacy (multiple SB)
+    bool IsValidSuperBlockTx(const CTransaction& txNew, int nBlockHeight) const;                                          // v6.0: single SB
+
     std::string GetRequiredPaymentsString(int nBlockHeight);
     bool FillBlockPayee(CMutableTransaction& txCoinbase, CMutableTransaction& txCoinstake, const int nHeight, bool fProofOfStake) const;
 

src/budget/finalizedbudget.cpp

@@ -7,6 +7,7 @@
 
 #include "chainparams.h"
 #include "masternodeman.h"
+#include "utilmoneystr.h"
 #include "validation.h"
 
 CFinalizedBudget::CFinalizedBudget() :
@@ -390,6 +391,38 @@ bool CFinalizedBudget::GetPayeeAndAmount(int64_t nBlockHeight, CScript& payee, C
     return true;
 }
 
+bool CFinalizedBudget::AllBudgetsPaid(const CTransaction& tx) const
+{
+    // make a map for faster lookup and deal with duplicate payees
+    struct cmp {
+        bool operator()(const CTxOut& a, const CTxOut& b) const
+        {
+            return a.scriptPubKey < b.scriptPubKey ||
+                   (a.scriptPubKey == b.scriptPubKey && a.nValue < b.nValue);
+        }
+    };
+    std::map<CTxOut, int, cmp> txouts;
+    for (const CTxOut& o : tx.vout) {
+        txouts[o]++;
+    }
+
+    for (const CTxBudgetPayment& payment : vecBudgetPayments) {
+        auto it = txouts.find(CTxOut(payment.nAmount, payment.payee));
+        if (it == txouts.end() || it->second == 0) {
+            // Payment not found
+            CTxDestination addr;
+            const std::string& payee = ExtractDestination(payment.payee, addr) ? EncodeDestination(addr) : HexStr(payment.payee);
+            LogPrint(BCLog::MNBUDGET, "Missing payment of %s for %s (proposal hash: %s)\n",
+                FormatMoney(payment.nAmount), payee, payment.nProposalHash.ToString());
+            return false;
+        }
+        it->second--;
+    }
+
+    // all budgets are paid by tx
+    return true;
+}
+
 // return broadcast serialization
 CDataStream CFinalizedBudget::GetBroadcast() const
 {

src/budget/finalizedbudget.h

@@ -93,6 +93,9 @@ class CFinalizedBudget
     bool GetBudgetPaymentByBlock(int64_t nBlockHeight, CTxBudgetPayment& payment) const;
     bool GetPayeeAndAmount(int64_t nBlockHeight, CScript& payee, CAmount& nAmount) const;
 
+    // Check if ALL the budgets are paid by transaction tx
+    bool AllBudgetsPaid(const CTransaction& tx) const;
+
     // Check finalized budget proposals. Masternodes only (when voting on finalized budgets)
     bool CheckProposals(const std::map<uint256, CBudgetProposal>& mapWinningProposals) const;
     // Total amount paid out by this budget

src/masternode-payments.cpp

@@ -318,7 +318,7 @@ bool IsBlockPayeeValid(const CBlock& block, const CBlockIndex* pindexPrev)
 
     // Check budget payments during superblocks
     if (sporkManager.IsSporkActive(SPORK_13_ENABLE_SUPERBLOCKS) && consensus.IsSuperBlock(nBlockHeight)) {
-        // !TODO...
+        return g_budgetman.IsValidSuperBlockTx(coinbase_tx, nBlockHeight);
     }
 
     return true;