fix: Use local variables in property context #1419
Draft
+343
−997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volsa
commented
Mar 1, 2025
| @@ -403,3 +403,38 @@ fn argument_fed_by_ref_then_by_val() { | |||
|
|
|||
| insta::assert_snapshot!(result) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn properties_are_not_registered_as_variables_in_a_pou() { | |||
There was a problem hiding this comment.
This needs fixing, as the codegen function doesn't make any use of lowering therefore always returning a correct result here.
volsa
commented
Mar 1, 2025
Comment on lines
692
to
695
| if m.is_property() { | ||
| // We want to ignore properties | ||
| continue; | ||
| } |
There was a problem hiding this comment.
self-note: Another approach might be removing the internally created property variable after lowering method calls. However, the following code will then no longer return a duplicate symbol error, which is is needed because properties are accessed like variables (e.g. instance.myprop := 5;).
VAR
foo : DINT
END_VAR
PROPERTY foo : DINT
// ...
END_PROPERTY
...meaning properties are part of the (IR) POU struct again but at least the tests are working again (still needs fixing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: https://github.com/PLC-lang/rusty/issues/14174
Edit: Currently the codegen does not ignore property variables, meaning they're still a part of the LLVM POU struct (which affects ffi)