Update build files to install standard library #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `install` stanza to `dune` files to install std and runtime to expected directories Delete manual copying from `install` scenario in `Makefile`
Kakadu
reviewed
Nov 12, 2024
|
А зачем мы копируем сырцы стандартной библиотеки? |
Кажется для компилятора они не нужны, но LSP без них не работал |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Обновил сборку через dune. До этого фикса при установке пакета через opam файлы стандартной библиотеки и рантайма не копировались в нужные директории.
Искомые директории подсмотрел в Makefile. Правда, обратил внимание, что исходные коды стандартной библиотеки копировались неправильно.
Для удобных директив в dune файлах обновил версию синтаксиса в dune-project. Надеюсь, что это не breaking change, по крайней мере, когда я тестировал, у меня ничего не сломалось.