Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Фикс рантайма remove_images_from_clients #254

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Фикс рантайма remove_images_from_clients #254

merged 2 commits into from
Sep 8, 2024

Conversation

Waselon
Copy link
Collaborator

@Waselon Waselon commented Sep 8, 2024 

RUNTIME: runtime error: Cannot read null.images
 - proc name: remove images from clients (/proc/remove_images_from_clients)
 -   source file: code/__HELPERS/game.dm,94
 -   usr: Mature Hunter (If) (/mob/living/carbon/xenomorph/hunter)
 -   src: null
 -   usr.loc: the cave (181,73,2) (/turf/open/floor/plating/ground/mars/random/cave)
 -   call stack:
 - remove images from clients(, /list (/list))
 - /datum/callback (/datum/callback): Invoke()
 - world: PushUsr(Mature Hunter (If) (/mob/living/carbon/xenomorph/hunter), /datum/callback (/datum/callback))
 - /datum/callback (/datum/callback): InvokeAsync()
 - Timer (/datum/controller/subsystem/timer): fire(0)
 - Timer (/datum/controller/subsystem/timer): ignite(0)
 - Master (/datum/controller/master): RunQueue()
 - Master (/datum/controller/master): Loop(2)
 - Master (/datum/controller/master): StartProcessing(0)

@Waselon
Update game.dm
bcedee0 
Signed-off-by: Waselon <[email protected]>
@Tatarla Tatarla added the Fix Исправление или правка. label Sep 8, 2024
@Tatarla Tatarla assigned homexp13 and Helg2 and unassigned homexp13 and Helg2 Sep 8, 2024
@Tatarla Tatarla requested review from homexp13 and Helg2 September 8, 2024 08:26
Helg2
Helg2 reviewed Sep 8, 2024
View reviewed changes
code/__HELPERS/game.dm Outdated
Comment on lines 93 to 94
for(var/client/C AS in show_to)
C.images -= I
C?.images -= I
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Просто убери AS?

@Waselon
Update game.dm
269fc32 
Signed-off-by: Waselon <[email protected]>
Helg2
Helg2 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@Helg2 Helg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну вроде норм

@Tatarla Tatarla merged commit b45f78e into PMC-Unga-Marines:master Sep 8, 2024
6 checks passed
@Helg2
Copy link
Collaborator

Helg2 commented Sep 8, 2024

Хотя возможно все сломается xd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helg2 Helg2 Helg2 approved these changes

@homexp13 homexp13 Awaiting requested review from homexp13

Assignees
No one assigned
Labels
Fix Исправление или правка.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Waselon @Helg2 @homexp13 @Tatarla