Ventcrawl port #751
Ventcrawl port #751
Conversation
|
Вроде все работает нормально, но при инициализации spatial grid говорится что инициализация закончилась с ошибками (в игре) |
|
Ахуй ты герой |
Tatarla
added
Port
|
Проверь правильно ли работает блокирование выхода из вентиляции если она закрыта шаттлом/стеной. |
|
Это портил? tgstation/tgstation#68693 |
Нет, ибо там вроде он прост выпиливает проверки из хандлер и делает отдельным проком, но половина проков нам не нужна ибо там проки для людей которых у нас вроде не было... |
code/modules/atmospherics/machinery/components/unary_devices/vent_pump.dm
Outdated
Show resolved
Hide resolved
code/modules/atmospherics/machinery/components/unary_devices/cryo.dm
Outdated
Show resolved
Hide resolved
code/modules/atmospherics/machinery/components/unary_devices/vent_scrubber.dm
Outdated
Show resolved
Hide resolved
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
| visible_message(span_notice("[stealthy ? "[src] begins climbing into the ventilation system..." : ""]"),span_notice("You begin climbing into the ventilation system...")) | ||
|
|
||
| if(!do_after(src, crawl_time, IGNORE_HELD_ITEM, vent_found, BUSY_ICON_GENERIC) || !client || !canmove) | ||
| if(vent_movement & VENTCRAWL_ENTRANCE_ALLOWED) |
There was a problem hiding this comment.
Ранний ретурн можно сделать
| if(!do_after(src, crawl_time, target = ventcrawl_target))\ | ||
| return |
There was a problem hiding this comment.
При не выполненном do_after сделай отмену кд через TIMER_COOLDOWN_END чтобы можно было при отмене выхода из вентиляции повторно попробовать выйти не ожидая 2 секунды.
| climb_out(user, loc) | ||
| if(TIMER_COOLDOWN_CHECK(user, COOLDOWN_VENTCRAWL)) | ||
| return FALSE | ||
| TIMER_COOLDOWN_START(user, COOLDOWN_VENTCRAWL, 2 SECONDS) |
There was a problem hiding this comment.
Таймер бы выставить на то же время что и время выхода из вентиляции.
Основные измененияПортирование этих двух ПРов улучшение кода и фикс нагрузки из-за венты
Но есть несколько но, затронута система радио и вообще болтовни, возможно будут какие-то баги с ней, или наоборот, меньше проблем. Возможно не полностью фиксит проблему с нагрузкой ползанья, но сам процесс стал приятнее.
Как это улучшит игруМеньше лагов, теперь по венте более приятно ползать.
Ченджлог